[GitHub] risdenk commented on a change in pull request #59: KNOX-1789 - Refactor RemoteAliasService to use service loading

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #59: KNOX-1789 - Refactor RemoteAliasService to use service loading
URL: https://github.com/apache/knox/pull/59#discussion_r259984585
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/services/CLIGatewayServices.java
 ##########
 @@ -70,16 +54,21 @@ public void init(GatewayConfig config, Map<String,String> options) throws Servic
     defaultAlias.setKeystoreService(ks);
     defaultAlias.init(config, options);
 
+    final RemoteConfigurationRegistryClientService registryClientService =
+        RemoteConfigurationRegistryClientServiceFactory.newInstance(config);
+    registryClientService.setAliasService(defaultAlias);
 
 Review comment:
   Doesn't make sense for this to be set to the remote alias service since this could be remote itself. This uses the default alias service in case of digest authentication.
   
   If digest auth and using remote alias service, then wouldn't be able to connect to ZK anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services