You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/10/29 09:11:01 UTC

[GitHub] [mynewt-nimble] fjmolinas commented on a change in pull request #1065: nimble/host/include/host/ble_gap: expose ble_gap_adv_active_instance

fjmolinas commented on a change in pull request #1065:
URL: https://github.com/apache/mynewt-nimble/pull/1065#discussion_r739067366



##########
File path: nimble/host/src/ble_gap.c
##########
@@ -1294,14 +1294,12 @@ ble_gap_master_in_progress(void)
 #endif
 }
 
-#if NIMBLE_BLE_ADVERTISE || NIMBLE_BLE_CONNECT
-static int
+int
 ble_gap_adv_active_instance(uint8_t instance)
 {
     /* Assume read is atomic; mutex not necessary. */

Review comment:
       I had done that initially, but the function is used in legacy api code, just with instance=0 and so travis complained. I could wrap the `static` qualifier based on `EXT_ADV` ifdef. Would that be ok?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org