You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Sanjay Radia (JIRA)" <ji...@apache.org> on 2008/08/23 01:18:46 UTC
[jira] Created: (HADOOP-4006) Cleanup HDFS FSConstants
Cleanup HDFS FSConstants
------------------------
Key: HADOOP-4006
URL: https://issues.apache.org/jira/browse/HADOOP-4006
Project: Hadoop Core
Issue Type: Sub-task
Reporter: Sanjay Radia
Fix For: 0.19.0
* Remove RPC Codes - they are unused
* Move the data node streaming constants into its own interfaces/class
* Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632892#action_12632892 ]
Sanjay Radia commented on HADOOP-4006:
--------------------------------------
Deriving DataTransferProtocol from VersionedProtocol is a good idea. Due to the .19 freeze today I won't be able to make it. I suggest we do it as part of Hadoop-4008.
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch, refactorConstants5.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632856#action_12632856 ]
Konstantin Shvachko commented on HADOOP-4006:
---------------------------------------------
- I like {{DataTransferProtocol}}. I was thinking about creating such a class and placing common data transfer methods in it. Say, serialization of block locations, opening sockets, verifying replies can belong to this protocol. Right now we duplicate code in different places rather than reusing it.
More, this protocol is used not only for client-to-data-node communication but also between data-nodes themselves.
- Although it is not an ipc protocol it is still versioned, so I'm +1 to derive DataTransferProtocol from VersionedProtocol.
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4006:
------------------------------------
Component/s: dfs
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632808#action_12632808 ]
Raghu Angadi commented on HADOOP-4006:
--------------------------------------
It is not a Hadoop RPC protocol.
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-4006:
---------------------------------
Attachment: refactorConstants5.patch
Did the class rename as Raghu suggested.
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch, refactorConstants5.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634136#action_12634136 ]
Hudson commented on HADOOP-4006:
--------------------------------
Integrated in Hadoop-trunk #613 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/613/])
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.20.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch, refactorConstants5.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-4006:
---------------------------------
Attachment: refactorConstants2.patch
Moves many FSConstants to server.common.HdfsConstants, to ClientDatanodeStreamIngProtocol.
Removed the unused RPC constants.
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley reopened HADOOP-4006:
-----------------------------------
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch, refactorConstants5.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631981#action_12631981 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4006:
------------------------------------------------
Forgot to add ClientDatanodeStreamingProtocol.java?
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633301#action_12633301 ]
Hudson commented on HADOOP-4006:
--------------------------------
Integrated in Hadoop-trunk #611 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/611/])
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch, refactorConstants5.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi resolved HADOOP-4006.
----------------------------------
Resolution: Fixed
Release Note: Clean up FSConstants and move some of the constants to better places.
Hadoop Flags: [Reviewed]
I just committed this. Thanks Sanjay!
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch, refactorConstants5.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4006:
------------------------------------
Release Note: (was: Clean up FSConstants and move some of the constants to better places.)
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.20.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch, refactorConstants5.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-4006:
---------------------------------
Attachment: refactorConstants3.patch
Forgot to add ClientDatanodeStreamingProtocol.java to svn.
Update patch with that missing java class.
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi reassigned HADOOP-4006:
------------------------------------
Assignee: Sanjay Radia
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch, refactorConstants5.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632764#action_12632764 ]
Raghu Angadi commented on HADOOP-4006:
--------------------------------------
I would recommend renaming {{ClientDatanodeStreamingProtocol}} to {{DataTransferProtocol}}.. since this what we refer to as. The protocol applies between datanodes as well.
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632803#action_12632803 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4006:
------------------------------------------------
This might belong to a different issue: ClientDatanodeStreamingProtocol (or DataTransferProtocol) should extend VersionedProtocol.
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-4006:
---------------------------------
Attachment: refactorConstants4.patch
Updated patch to account for recent truck changes.
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Fix For: 0.19.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-4006) Cleanup HDFS FSConstants
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley resolved HADOOP-4006.
-----------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.19.0)
0.20.0
It was committed after the 0.19 branch.
> Cleanup HDFS FSConstants
> ------------------------
>
> Key: HADOOP-4006
> URL: https://issues.apache.org/jira/browse/HADOOP-4006
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Fix For: 0.20.0
>
> Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch, refactorConstants5.patch
>
>
> * Remove RPC Codes - they are unused
> * Move the data node streaming constants into its own interfaces/class
> * Remove the extends FSConstants
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.