You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/05 12:02:48 UTC

[GitHub] [pulsar-client-go] wolfstudy commented on a diff in pull request #938: [feature] Support batch index ACK

wolfstudy commented on code in PR #938:
URL: https://github.com/apache/pulsar-client-go/pull/938#discussion_r1062395498


##########
pulsar/impl_message.go:
##########
@@ -21,36 +21,38 @@ import (
 	"errors"
 	"fmt"
 	"math"
-	"math/big"
-	"strings"
 	"sync"
 	"sync/atomic"
 	"time"
 
 	"google.golang.org/protobuf/proto"
 
 	pb "github.com/apache/pulsar-client-go/pulsar/internal/pulsar_proto"
+	"github.com/bits-and-blooms/bitset"
 )
 
 type messageID struct {
 	ledgerID     int64
 	entryID      int64
 	batchIdx     int32
 	partitionIdx int32
+	batchSize    int32

Review Comment:
   Please do not add new field information in this structure, otherwise the expression of messageID is not very correct, and there will be performance problems. Refer to the repair of this pr: https://github.com/apache/pulsar-client-go/pull/316



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org