You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/09 23:34:36 UTC

[GitHub] [airflow] youngyjd opened a new pull request #5074: [AIRFLOW-XXX] Update SlackWebhookOperator and SlackWebhookHook docstring

youngyjd opened a new pull request #5074: [AIRFLOW-XXX] Update SlackWebhookOperator and SlackWebhookHook docstring
URL: https://github.com/apache/airflow/pull/5074
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] No Jira. Updating documentation.
   
   ### Description
   
   - [X] If both Slack webhook token and http_conn_id is provided, SlackWebhookOperator and SlackWebhookHook will not take token as the absolute path, but use http_conn_id as base_url and webhook token as relative path. This is in line with SlackWebhookHook's superclass HttpHook's design idea. https://github.com/apache/airflow/blob/7ac82196b2a2eac43feb3060cffb4e6092a3afb7/airflow/hooks/http_hook.py#L64-L72
   https://github.com/apache/airflow/blob/7ac82196b2a2eac43feb3060cffb4e6092a3afb7/airflow/hooks/http_hook.py#L103-L108
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services