[superset] branch master updated: fix(ui): Quick Fix for app_icon (#21399)

[cr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

craigrueda pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 9ada541fd9 fix(ui): Quick Fix for app_icon (#21399)
9ada541fd9 is described below

commit 9ada541fd9a69b4bc6c3d1095e5c60f6c7dc955a
Author: Craig Rueda <cr...@craigrueda.com>
AuthorDate: Fri Sep 9 09:57:19 2022 -0500

    fix(ui): Quick Fix for app_icon (#21399)
---
 superset/templates/superset/basic.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/templates/superset/basic.html b/superset/templates/superset/basic.html
index fff57fdb9f..fdd2e8e0de 100644
--- a/superset/templates/superset/basic.html
+++ b/superset/templates/superset/basic.html
@@ -40,7 +40,7 @@
           rel="{{favicon.rel if favicon.rel else "icon"}}"
           type="{{favicon.type if favicon.type else "image/png"}}"
           {% if favicon.sizes %}sizes={{favicon.sizes}}{% endif %}
-          href="{{ assets_prefix }}{{favicon.href}}"
+          href="{{ "" if favicon.href.startswith("http") else assets_prefix }}{{favicon.href}}"
         >
       {% endfor %}
       <link rel="stylesheet" type="text/css" href="{{ assets_prefix }}/static/appbuilder/css/flags/flags16.css" />