You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Jasvir Nagra (JIRA)" <ji...@apache.org> on 2008/10/16 02:50:44 UTC
[jira] Created: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Injecting feature javascript into head breaks caja
--------------------------------------------------
Key: SHINDIG-654
URL: https://issues.apache.org/jira/browse/SHINDIG-654
Project: Shindig
Issue Type: Bug
Components: Features (Javascript), Gadget Rendering Server (Java)
Reporter: Jasvir Nagra
The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasvir Nagra updated SHINDIG-654:
---------------------------------
Attachment: valija-upgrade-patch4.txt
* Added the enableCaja to CajaContentRewriter as suggested by entu
* Moved the container setup required by caja to caja.js (setup valijaMaker and give permission to the gadget to use console to log errors)
* Added simple tests to ensure caja is operating (adding more substantial tests in another patch)
* Added SocialCajaWorld.xml to examples
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt, valija-upgrade-patch2.txt, valija-upgrade-patch3.txt, valija-upgrade-patch4.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasvir Nagra updated SHINDIG-654:
---------------------------------
Attachment: valija-upgrade-patch.txt
This is a partial fix that corrects the names of the new globals for caja, the missing setup of valija and uses a more sensible test for whether caja is enabled.
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Attachments: valija-upgrade-patch.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasvir Nagra reopened SHINDIG-654:
----------------------------------
Attached patch to fully resolve the issue
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasvir Nagra updated SHINDIG-654:
---------------------------------
Attachment: complete-valija-patch.txt
This fixes the remaining issue with caja being injected entirely into head and re-enables caja for gadgets.
* Thanks to Ihab with whom I worked on this patch. We've separated out the assembly of the final gadget in RenderingContentRewriter into more buckets than just head and body because it was already becoming rather messy, dependent on the order of method calls and difficult to follow. Now the order is decided completely by assemble(). I think this makes it easier to re-order the constructed gadget if some re-ordering is desired in the future.
* Changed allowRead and allowCall to grantRead and grantCall as per the new caja api
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-654) Injecting feature javascript into head
breaks caja
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown closed SHINDIG-654.
-------------------------------
Resolution: Fixed
Assignee: Kevin Brown
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: valija-upgrade-patch.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown resolved SHINDIG-654.
---------------------------------
Resolution: Fixed
Fix Version/s: trunk
Patch looks good, so I've applied it.
Thanks for the update.
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Fix For: trunk
>
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt, valija-upgrade-patch2.txt, valija-upgrade-patch3.txt, valija-upgrade-patch4.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasvir Nagra updated SHINDIG-654:
---------------------------------
Attachment: (was: complete-valija-patch.txt)
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649224#action_12649224 ]
Brian Eaton commented on SHINDIG-654:
-------------------------------------
EndToEndTest.java: why change this to add a test case that is commented out?
RenderingContentRewiter.java: please add comments explaining the semantics of each Part value.
RenderingContentRewriterTest.java: please add tests for the semantics of each part value.
RenderingContentRewriter.java: this patch does not apply cleanly to shindig HEAD:
patching file java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
patching file java/server/src/test/resources/endtoend/cajaTest.xml
patching file java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingContentRewriterTest.java
Hunk #1 FAILED at 316.
1 out of 1 hunk FAILED -- saving rejects to file java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingContentRewriterTest.java.rej
patching file java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingContentRewriter.java
Hunk #1 succeeded at 59 with fuzz 1 (offset 6 lines).
Hunk #2 succeeded at 95 (offset -2 lines).
Hunk #3 FAILED at 138.
Hunk #4 FAILED at 162.
Hunk #5 FAILED at 186.
Hunk #6 succeeded at 236 (offset 37 lines).
Hunk #7 FAILED at 243.
Hunk #8 FAILED at 407.
Hunk #9 FAILED at 424.
Hunk #10 FAILED at 450.
Hunk #11 FAILED at 464.
Hunk #12 FAILED at 483.
Hunk #13 FAILED at 511.
10 out of 13 hunks FAILED -- saving rejects to file java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingContentRewriter.java.rej
patching file java/gadgets/src/main/java/org/apache/shindig/gadgets/JsFeatureLoader.java
patching file java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java
patching file features/opensocial-reference/container.js
patching file features/caja/feature.xml
patching file features/opensocial-current/feature.xml
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt, valija-upgrade-patch2.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasvir Nagra updated SHINDIG-654:
---------------------------------
Attachment: complete-valija-patch.txt
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasvir Nagra updated SHINDIG-654:
---------------------------------
Attachment: valija-upgrade-patch3.txt
Updated patch - the patch was greatly simplified because of lryans's recent refactoring of RenderingContentRewritereringContent. In particular, it removes the need for additional parts. Re-added the caja test which were missing from the last patch.
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt, valija-upgrade-patch2.txt, valija-upgrade-patch3.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650409#action_12650409 ]
Jasvir Nagra commented on SHINDIG-654:
--------------------------------------
Agreed that would be better. I'll make that change.
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt, valija-upgrade-patch2.txt, valija-upgrade-patch3.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasvir Nagra updated SHINDIG-654:
---------------------------------
Attachment: valija-upgrade-patch2.txt
Updated patch - resync'ed
Removes caja from SocialHelloWorld example.
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt, valija-upgrade-patch2.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650403#action_12650403 ]
Kevin Brown commented on SHINDIG-654:
-------------------------------------
This code effectively stops all code from being injected that isn't <inbody>. Instead of doing all this, why not just append the relevant script node in CajaContentRewriter?
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt, valija-upgrade-patch2.txt, valija-upgrade-patch3.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-654) Injecting feature javascript into
head breaks caja
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650402#action_12650402 ]
Brian Eaton commented on SHINDIG-654:
-------------------------------------
There are now two calls to enableCaja in opensocial-current/feature.xml. Why?
RenderingContentRewriter.java: please remove extra whitespace.
RenderingContentRewriter.java. please include brackets in if-blocks, even if they are only a single statement.
container.js: what do these changes do?
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt, valija-upgrade-patch2.txt, valija-upgrade-patch3.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml. The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before. As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.