You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/11 00:35:00 UTC
[jira] [Commented] (CB-12966) cordova-ios Podfile template does not
escape project names containing a single quote
[ https://issues.apache.org/jira/browse/CB-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081429#comment-16081429 ]
ASF GitHub Bot commented on CB-12966:
-------------------------------------
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/324
Not passing the linter:
```
bin\templates\scripts\cordova\lib\Podfile.js: line 93, col 51, Mixed double and single quotes.
bin\templates\scripts\cordova\lib\Podfile.js: line 93, col 59, Mixed double and single quotes.
```
Basically the style for this repo is strings are single quoted. So you would reverse your escaping in line 93
> cordova-ios Podfile template does not escape project names containing a single quote
> ------------------------------------------------------------------------------------
>
> Key: CB-12966
> URL: https://issues.apache.org/jira/browse/CB-12966
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Affects Versions: cordova-ios@4.4.0, cordova-ios@5.0.0
> Environment: iOS platform
> Reporter: Josh Holtz
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: ios, patch
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The Podfile template does not escape single quotes for project names when generating the Podfile. This will cause a syntax error in the Podfile since the target and project are single quoted strings. The solution is to escape the single quotes in the project name before writing them to the Podfile.
> I already have a fix for this issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org