You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/11 10:54:28 UTC

[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11368: [Feature-7024] Add waiting strategy to support master/worker can recover from registry lost

ruanwenjun commented on code in PR #11368:
URL: https://github.com/apache/dolphinscheduler/pull/11368#discussion_r943350978


##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/cron/CronUtils.java:
##########
@@ -147,7 +143,7 @@ public static List<ZonedDateTime> getFireDateList(@NonNull ZonedDateTime startTi
         List<ZonedDateTime> dateList = new ArrayList<>();
         ExecutionTime executionTime = ExecutionTime.forCron(cron);
 
-        while (Stopper.isRunning()) {
+        while (!ServerLifeCycleManager.isStopped()) {

Review Comment:
   Yes, we don't need to check the server status in all places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org