You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/02 18:52:44 UTC
[GitHub] [incubator-gobblin] sv2000 opened a new pull request #3023: GOBBLIN-1177: Provide a config for overprovisioning Gobblin Yarn cont…
sv2000 opened a new pull request #3023:
URL: https://github.com/apache/incubator-gobblin/pull/3023
…ainers by a configurable amount
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1177
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Over-provisioning config can be used to spin up a fleet of spare containers to allow Helix to reassign tasks to away from unhealthy containers (e.g. containers that experience persistent task failures due to N/W issues) to the potentially healthy spare containers.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3023: GOBBLIN-1177: Provide a config for overprovisioning Gobblin Yarn cont…
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3023:
URL: https://github.com/apache/incubator-gobblin/pull/3023#issuecomment-637783727
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=h1) Report
> Merging [#3023](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/2747b8d31f022388fc6808d0fbea5177c343c644&el=desc) will **increase** coverage by `4.23%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3023 +/- ##
============================================
+ Coverage 41.47% 45.71% +4.23%
- Complexity 8466 9291 +825
============================================
Files 1951 1951
Lines 74241 74244 +3
Branches 8215 8215
============================================
+ Hits 30790 33938 +3148
+ Misses 40533 37132 -3401
- Partials 2918 3174 +256
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/gobblin/yarn/YarnAutoScalingManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkF1dG9TY2FsaW5nTWFuYWdlci5qYXZh) | `51.28% <25.00%> (-1.35%)` | `1.00 <0.00> (ø)` | |
| [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `57.14% <0.00%> (-2.12%)` | `24.00% <0.00%> (-2.00%)` | |
| [...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=) | `47.57% <0.00%> (-1.95%)` | `12.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `34.92% <0.00%> (ø)` | `14.00% <0.00%> (+1.00%)` | |
| [...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh) | `67.26% <0.00%> (+0.22%)` | `84.00% <0.00%> (+1.00%)` | |
| [.../org/apache/gobblin/runtime/SafeDatasetCommit.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU2FmZURhdGFzZXRDb21taXQuamF2YQ==) | `47.31% <0.00%> (+0.48%)` | `29.00% <0.00%> (ø%)` | |
| [...ache/gobblin/cluster/GobblinHelixMultiManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TXVsdGlNYW5hZ2VyLmphdmE=) | `53.64% <0.00%> (+0.52%)` | `17.00% <0.00%> (+1.00%)` | |
| [...main/java/org/apache/gobblin/util/ConfigUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQ29uZmlnVXRpbHMuamF2YQ==) | `58.86% <0.00%> (+0.63%)` | `41.00% <0.00%> (+1.00%)` | |
| [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `60.36% <0.00%> (+0.77%)` | `37.00% <0.00%> (+2.00%)` | |
| [...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=) | `75.00% <0.00%> (+0.83%)` | `68.00% <0.00%> (ø%)` | |
| ... and [149 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=footer). Last update [2747b8d...8be8181](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter commented on pull request #3023: GOBBLIN-1177: Provide a config for overprovisioning Gobblin Yarn cont…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3023:
URL: https://github.com/apache/incubator-gobblin/pull/3023#issuecomment-637783727
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=h1) Report
> Merging [#3023](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/2747b8d31f022388fc6808d0fbea5177c343c644&el=desc) will **increase** coverage by `4.23%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3023 +/- ##
============================================
+ Coverage 41.47% 45.71% +4.23%
- Complexity 8466 9291 +825
============================================
Files 1951 1951
Lines 74241 74244 +3
Branches 8215 8215
============================================
+ Hits 30790 33938 +3148
+ Misses 40533 37132 -3401
- Partials 2918 3174 +256
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/gobblin/yarn/YarnAutoScalingManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkF1dG9TY2FsaW5nTWFuYWdlci5qYXZh) | `51.28% <25.00%> (-1.35%)` | `1.00 <0.00> (ø)` | |
| [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `57.14% <0.00%> (-2.12%)` | `24.00% <0.00%> (-2.00%)` | |
| [...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=) | `47.57% <0.00%> (-1.95%)` | `12.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `34.92% <0.00%> (ø)` | `14.00% <0.00%> (+1.00%)` | |
| [...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh) | `67.26% <0.00%> (+0.22%)` | `84.00% <0.00%> (+1.00%)` | |
| [.../org/apache/gobblin/runtime/SafeDatasetCommit.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU2FmZURhdGFzZXRDb21taXQuamF2YQ==) | `47.31% <0.00%> (+0.48%)` | `29.00% <0.00%> (ø%)` | |
| [...ache/gobblin/cluster/GobblinHelixMultiManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TXVsdGlNYW5hZ2VyLmphdmE=) | `53.64% <0.00%> (+0.52%)` | `17.00% <0.00%> (+1.00%)` | |
| [...main/java/org/apache/gobblin/util/ConfigUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQ29uZmlnVXRpbHMuamF2YQ==) | `58.86% <0.00%> (+0.63%)` | `41.00% <0.00%> (+1.00%)` | |
| [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `60.36% <0.00%> (+0.77%)` | `37.00% <0.00%> (+2.00%)` | |
| [...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=) | `75.00% <0.00%> (+0.83%)` | `68.00% <0.00%> (ø%)` | |
| ... and [149 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3023/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=footer). Last update [2747b8d...8be8181](https://codecov.io/gh/apache/incubator-gobblin/pull/3023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3023: GOBBLIN-1177: Provide a config for overprovisioning Gobblin Yarn cont…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3023:
URL: https://github.com/apache/incubator-gobblin/pull/3023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org