You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by jm...@apache.org on 2011/09/05 18:38:43 UTC

Review Request: FLUME-758: Test Excludes on maven build doesn't always work

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1716/
-----------------------------------------------------------

Review request for Flume, Arvind Prabhakar and Eric Sammer.


Summary
-------

commit 27e37dade789b8f77b313573e33fd8fb4d652405
Author: Jonathan Hsieh <jo...@cloudera.com>
Date:   Sun Sep 4 12:24:27 2011 -0700

    FLUME-758: Test Excludes on maven build doesn't always work
    
    Surefire 2.8.1 does not allow for lists of excluded tests to be specified via command line.
    We force the build to use surefire 2.6 which does.
    
    Verions 2.9, 2.8, 2.7.2, 2.7.1 and 2.7 were also tested and they failed to exclude.


This addresses bug flume-758.
    https://issues.apache.org/jira/browse/flume-758


Diffs
-----

  pom.xml d93d7de 

Diff: https://reviews.apache.org/r/1716/diff


Testing
-------

Tested against versions specified above.


Thanks,

jmhsieh

Re: Review Request: FLUME-758: Test Excludes on maven build doesn't always work

Posted by Eric Sammer <es...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1716/#review1748
-----------------------------------------------------------

Ship it!


lgtm. I'm sure it's obvious but we should file a surefire bug upstream.

- Eric


On 2011-09-05 16:57:00, jmhsieh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1716/
> -----------------------------------------------------------
> 
> (Updated 2011-09-05 16:57:00)
> 
> 
> Review request for Flume, Arvind Prabhakar and Eric Sammer.
> 
> 
> Summary
> -------
> 
> commit 27e37dade789b8f77b313573e33fd8fb4d652405
> Author: Jonathan Hsieh <jo...@cloudera.com>
> Date:   Sun Sep 4 12:24:27 2011 -0700
> 
>     FLUME-758: Test Excludes on maven build doesn't always work
>     
>     Surefire 2.8.1 does not allow for lists of excluded tests to be specified via command line.
>     We force the build to use surefire 2.6 which does.
>     
>     Verions 2.9, 2.8, 2.7.2, 2.7.1 and 2.7 were also tested and they failed to exclude.
> 
> 
> This addresses bug flume-758.
>     https://issues.apache.org/jira/browse/flume-758
> 
> 
> Diffs
> -----
> 
>   pom.xml d93d7de 
> 
> Diff: https://reviews.apache.org/r/1716/diff
> 
> 
> Testing
> -------
> 
> Tested against versions specified above.
> 
> Version 2.8.1 based build.
> jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern="**/TestA*.java,**/TestF*.java"
> ...
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running dk.brics.automaton.TestAutomaton
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.089 sec
> Running com.cloudera.flume.shell.TestFlumeShell
> ...
> 
> Version 2.6 based build.
> jon@grimlock:~/proj/cdh-flume$ mvn test
> ...
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running com.cloudera.util.consistenthash.TestConsistentHash
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.288 sec
> Running com.cloudera.flume.master.TestMasterReport
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.487 sec
> Running com.cloudera.flume.agent.diskfailover.TestConcurrentDFOMan
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 17.853 sec
> Running com.cloudera.util.TestNetUtils
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.959 sec
> Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
> ^CDestroying 1 processes
> Destroying process..
> Destroyed 1 processes
> 
> jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern=**/TestC*.java,**/TestM*.java
> ...
> Running com.cloudera.util.TestNetUtils
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.65 sec
> Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
> ^CDestroying 1 processes
> 
> 
> Thanks,
> 
> jmhsieh
> 
>

Re: Review Request: FLUME-758: Test Excludes on maven build doesn't always work

Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1716/#review1773
-----------------------------------------------------------

Ship it!


lgtm too.

- Arvind


On 2011-09-05 16:57:00, jmhsieh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1716/
> -----------------------------------------------------------
> 
> (Updated 2011-09-05 16:57:00)
> 
> 
> Review request for Flume, Arvind Prabhakar and Eric Sammer.
> 
> 
> Summary
> -------
> 
> commit 27e37dade789b8f77b313573e33fd8fb4d652405
> Author: Jonathan Hsieh <jo...@cloudera.com>
> Date:   Sun Sep 4 12:24:27 2011 -0700
> 
>     FLUME-758: Test Excludes on maven build doesn't always work
>     
>     Surefire 2.8.1 does not allow for lists of excluded tests to be specified via command line.
>     We force the build to use surefire 2.6 which does.
>     
>     Verions 2.9, 2.8, 2.7.2, 2.7.1 and 2.7 were also tested and they failed to exclude.
> 
> 
> This addresses bug flume-758.
>     https://issues.apache.org/jira/browse/flume-758
> 
> 
> Diffs
> -----
> 
>   pom.xml d93d7de 
> 
> Diff: https://reviews.apache.org/r/1716/diff
> 
> 
> Testing
> -------
> 
> Tested against versions specified above.
> 
> Version 2.8.1 based build.
> jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern="**/TestA*.java,**/TestF*.java"
> ...
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running dk.brics.automaton.TestAutomaton
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.089 sec
> Running com.cloudera.flume.shell.TestFlumeShell
> ...
> 
> Version 2.6 based build.
> jon@grimlock:~/proj/cdh-flume$ mvn test
> ...
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running com.cloudera.util.consistenthash.TestConsistentHash
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.288 sec
> Running com.cloudera.flume.master.TestMasterReport
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.487 sec
> Running com.cloudera.flume.agent.diskfailover.TestConcurrentDFOMan
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 17.853 sec
> Running com.cloudera.util.TestNetUtils
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.959 sec
> Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
> ^CDestroying 1 processes
> Destroying process..
> Destroyed 1 processes
> 
> jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern=**/TestC*.java,**/TestM*.java
> ...
> Running com.cloudera.util.TestNetUtils
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.65 sec
> Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
> ^CDestroying 1 processes
> 
> 
> Thanks,
> 
> jmhsieh
> 
>

Re: Review Request: FLUME-758: Test Excludes on maven build doesn't always work

Posted by jm...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1716/
-----------------------------------------------------------

(Updated 2011-09-05 16:57:00.394808)


Review request for Flume, Arvind Prabhakar and Eric Sammer.


Changes
-------

updated test info with example to prove this


Summary
-------

commit 27e37dade789b8f77b313573e33fd8fb4d652405
Author: Jonathan Hsieh <jo...@cloudera.com>
Date:   Sun Sep 4 12:24:27 2011 -0700

    FLUME-758: Test Excludes on maven build doesn't always work
    
    Surefire 2.8.1 does not allow for lists of excluded tests to be specified via command line.
    We force the build to use surefire 2.6 which does.
    
    Verions 2.9, 2.8, 2.7.2, 2.7.1 and 2.7 were also tested and they failed to exclude.


This addresses bug flume-758.
    https://issues.apache.org/jira/browse/flume-758


Diffs
-----

  pom.xml d93d7de 

Diff: https://reviews.apache.org/r/1716/diff


Testing (updated)
-------

Tested against versions specified above.

Version 2.8.1 based build.
jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern="**/TestA*.java,**/TestF*.java"
...
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running dk.brics.automaton.TestAutomaton
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.089 sec
Running com.cloudera.flume.shell.TestFlumeShell
...

Version 2.6 based build.
jon@grimlock:~/proj/cdh-flume$ mvn test
...
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.cloudera.util.consistenthash.TestConsistentHash
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.288 sec
Running com.cloudera.flume.master.TestMasterReport
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.487 sec
Running com.cloudera.flume.agent.diskfailover.TestConcurrentDFOMan
Tests run: 11, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 17.853 sec
Running com.cloudera.util.TestNetUtils
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.959 sec
Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
^CDestroying 1 processes
Destroying process..
Destroyed 1 processes

jon@grimlock:~/proj/cdh-flume$ mvn test -Dtest.exclude.pattern=**/TestC*.java,**/TestM*.java
...
Running com.cloudera.util.TestNetUtils
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.65 sec
Running com.cloudera.flume.agent.TestEndToEndAckFailureRecovery
^CDestroying 1 processes


Thanks,

jmhsieh