You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/24 09:46:56 UTC
[GitHub] [incubator-nuttx] Gary-Hobson opened a new pull request, #7680: drivers/segger: Add Segger RTT channel initialization
Gary-Hobson opened a new pull request, #7680:
URL: https://github.com/apache/incubator-nuttx/pull/7680
## Summary
Add Segger RTT channel initialization
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #7680: drivers/segger: Add Segger RTT channel initialization
Posted by GitBox <gi...@apache.org>.
Gary-Hobson commented on code in PR #7680:
URL: https://github.com/apache/nuttx/pull/7680#discussion_r1032595620
##########
drivers/segger/rtt_initialize.c:
##########
@@ -0,0 +1,53 @@
+/****************************************************************************
+ * drivers/segger/rtt_initialize.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <assert.h>
+
+#include <nuttx/config.h>
+#include <nuttx/kmalloc.h>
+#include <nuttx/segger/rtt.h>
+
+#include <SEGGER_RTT.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: rtt_channel_initialize
+ ****************************************************************************/
+
+void rtt_channel_initialize(int channel, FAR char * name,
Review Comment:
Initializing at system startup is a cleaner way
lib_rttoutstream_init may be called multiple times, which leads to the need to determine whether it has been initialized
Moreover, it is possible to write data through rtt_serial, but lib_rttoutstream_init is not called for initialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7680: drivers/segger: Add Segger RTT channel initialization
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7680:
URL: https://github.com/apache/nuttx/pull/7680#discussion_r1032560962
##########
drivers/segger/rtt_initialize.c:
##########
@@ -0,0 +1,53 @@
+/****************************************************************************
+ * drivers/segger/rtt_initialize.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <assert.h>
+
+#include <nuttx/config.h>
+#include <nuttx/kmalloc.h>
+#include <nuttx/segger/rtt.h>
+
+#include <SEGGER_RTT.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: rtt_channel_initialize
+ ****************************************************************************/
+
+void rtt_channel_initialize(int channel, FAR char * name,
Review Comment:
why not do the initialize in lib_rtt[out|in]stream_init?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on pull request #7680: drivers/segger: Add Segger RTT channel initialization
Posted by GitBox <gi...@apache.org>.
Gary-Hobson commented on PR #7680:
URL: https://github.com/apache/nuttx/pull/7680#issuecomment-1327564848
> @Gary-Hobson could you please include a Documentation/ about it?
Of course, I will submit a separate readme about the use of Segger J Link RTT later
Or submit it I use defconfig which is based on stm32 743ZI nucleo board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #7680: drivers/segger: Add Segger RTT channel initialization
Posted by GitBox <gi...@apache.org>.
Gary-Hobson commented on code in PR #7680:
URL: https://github.com/apache/nuttx/pull/7680#discussion_r1032595620
##########
drivers/segger/rtt_initialize.c:
##########
@@ -0,0 +1,53 @@
+/****************************************************************************
+ * drivers/segger/rtt_initialize.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <assert.h>
+
+#include <nuttx/config.h>
+#include <nuttx/kmalloc.h>
+#include <nuttx/segger/rtt.h>
+
+#include <SEGGER_RTT.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: rtt_channel_initialize
+ ****************************************************************************/
+
+void rtt_channel_initialize(int channel, FAR char * name,
Review Comment:
Initializing at system startup is a cleaner way
lib_rttoutstream_init may be called multiple times, which leads to the need to determine whether it has been initialized
Moreover, it is possible to write data through rtt_serial, but lib_rttoutstream_init is not called for initialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #7680: drivers/segger: Add Segger RTT channel initialization
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7680:
URL: https://github.com/apache/nuttx/pull/7680#issuecomment-1327389319
@Gary-Hobson could you please include a Documentation/ about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson closed pull request #7680: drivers/segger: Add Segger RTT channel initialization
Posted by GitBox <gi...@apache.org>.
Gary-Hobson closed pull request #7680: drivers/segger: Add Segger RTT channel initialization
URL: https://github.com/apache/nuttx/pull/7680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org