[GitHub] [commons-csv] garydgregory commented on pull request #295: [CSV-141] Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory commented on PR #295:
URL: https://github.com/apache/commons-csv/pull/295#issuecomment-1399319422

   I applied and then reverted this PR because it does not work. Notice the comment I made 2 weeks ago "A test is missing that an actual CSV file can be parsed and not parsed." This was never done, and sure enough, when I added a simple test based on the CSV file in the Jira description, it failed. Please see `CSVParserTest.testCSV141*` and in particular `testCSV141Excel`. You should:
   - Rebase on git master
   - Comment out of remove the `@Disabled` annotation for `testCSV141Excel` and see how the test fails when too much data is consumed.
   
   If you choose to continue this work in another PR, make sure to add tests similar to `testCSV141Excel` to assert various permutations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org