You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/09/19 19:37:16 UTC

[GitHub] [thrift] Jens-G commented on pull request #1859: THRIFT-4942: Generated fields privatized; add getters/setters

Jens-G commented on pull request #1859:
URL: https://github.com/apache/thrift/pull/1859#issuecomment-695348322


   **Personal opinion**: Make it an optional thing, and let the default as it is. This also putrs the burgden of the breaking change to those users who want it, at the places where they want it. With that change being implemented I have no objections. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org