You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2021/11/23 17:43:00 UTC

[jira] [Commented] (ARROW-14262) [C++] Document and rename is_in_meta_binary

    [ https://issues.apache.org/jira/browse/ARROW-14262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448154#comment-17448154 ] 

Antoine Pitrou commented on ARROW-14262:
----------------------------------------

The docstrings have been added in ARROW-14751 but the rest of this issue still holds.

> [C++] Document and rename is_in_meta_binary
> -------------------------------------------
>
>                 Key: ARROW-14262
>                 URL: https://issues.apache.org/jira/browse/ARROW-14262
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Weston Pace
>            Priority: Major
>              Labels: kernel
>
> The is_in_meta_binary and index_in_meta_binary functions do not have any "_doc" elements.  I had simply ignored them assuming they were some kind of specialized function that shouldn't be exposed for general consumption (see ARROW-13949) but I recently discovered they are legitimate binary variants of their unary counterparts.
> If we want to continue to expose these functions we should rename them (meta I assume means meta function but the python/r user has no idea what a meta function is) and add _doc elements.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)