You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/21 09:55:39 UTC

[GitHub] [airflow] XD-DENG commented on a change in pull request #9427: Remove redundant functions in airflow/security/utils.py

XD-DENG commented on a change in pull request #9427:
URL: https://github.com/apache/airflow/pull/9427#discussion_r443201665



##########
File path: airflow/security/utils.py
##########
@@ -56,26 +55,3 @@ def replace_hostname_pattern(components, host=None):
     if not fqdn or fqdn == '0.0.0.0':
         fqdn = get_hostname()
     return '%s/%s@%s' % (components[0], fqdn.lower(), components[2])
-
-
-def get_fqdn(hostname_or_ip=None):

Review comment:
       Agree with @potiuk . It makes more sense to deprecate first.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org