You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/21 09:20:00 UTC
[jira] [Commented] (GEODE-8601) Replace ACE ExpiryTaskManager impl
by boost::asio one
[ https://issues.apache.org/jira/browse/GEODE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269163#comment-17269163 ]
ASF GitHub Bot commented on GEODE-8601:
---------------------------------------
gaussianrecurrence commented on a change in pull request #678:
URL: https://github.com/apache/geode-native/pull/678#discussion_r561716554
##########
File path: cppcache/integration-test/CMakeLists.txt
##########
@@ -25,6 +25,7 @@ add_library(test-cppcache-utils STATIC
target_link_libraries(test-cppcache-utils
PRIVATE
ACE::ACE
+ Boost::boost
Review comment:
After changing CacheStatistics this is not needed anymore. Thanks!
##########
File path: cppcache/integration-test/CMakeLists.txt
##########
@@ -114,6 +115,7 @@ endif()
target_link_libraries(${TEST}
PRIVATE
ACE::ACE
+ Boost::boost
Review comment:
After changing CacheStatistics this is not needed anymore. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Replace ACE ExpiryTaskManager impl by boost::asio one
> -----------------------------------------------------
>
> Key: GEODE-8601
> URL: https://issues.apache.org/jira/browse/GEODE-8601
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS A* native client contributor
> *I WOULD LIKE* to replace ACE implementation of ExpiryTaskManager for a boost::asio one
> *SO THAT* all issues related to it disappear, the implementation is more simple and move away from ACE as it's the project policy for a while.
> —
> *Additional information*
> Current implementation of ExpiryTaskManager is causing issue GEODE-8535 and some other related, not yet reported.
> Also, as I am aware the project is moving away from ACE, so I'd say this is the perfect oportunity to replace ExpiryTaskManager implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)