[GitHub] samza pull request #834: SAMZA-2014: Samza-sql: Support table as both source...

[atoomula <gi...@git.apache.org>]

GitHub user atoomula opened a pull request:

    https://github.com/apache/samza/pull/834

    SAMZA-2014: Samza-sql: Support table as both source (for join) and destination in the same application

    While parsing queries in an application, with in SamzaSqlApplicationConfig, we collect all input sources and output sources from all queries and create descriptors for input sources first followed by output sources. But there could be only one table descriptor instance per table. Writable table is a readable table but vice versa is not true. If we go through input sources, we will end up creating readable table descriptor and would not be able to create writable table descriptor again when we go through output sources (the code will be ugly if we have to achieve this). There are couple of ways to solve this:
    - Always make a table readable and writable
    - Go through output sources first followed by input sources.
    
    Choosing option 2 as making a table always read-writable does not make sense.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/atoomula/samza table

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #834
    
----
commit 6b2c5efefb7c823b0f71baeb422b361aca1c0136
Author: Aditya Toomula <at...@...>
Date:   2018-11-30T19:04:37Z

    SAMZA-2014: Samza-sql: Support table as both source (for join) and destination in the same application

----


---

[GitHub] samza pull request #834: SAMZA-2014: Samza-sql: Support table as both source...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/834


---