You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/01/28 02:09:16 UTC
Review Request 42888: Used absolute paths for excludes paths in posix
disk isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42888/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
Repository: mesos
Description
-------
Used absolute paths for excludes paths in posix disk isolator.
We should consistently use absolute paths for excludes paths in disk isolator, otherwise, it's possible that some other paths under the directory matches the relative path, causing incorrect disk usage being reported.
Diffs
-----
src/slave/containerizer/mesos/isolators/posix/disk.hpp 5607c0f43084f491e4927f5c6ec283210aa5f355
src/slave/containerizer/mesos/isolators/posix/disk.cpp d5bf8c10b9cfb360a7856144d59ce89060de5c99
Diff: https://reviews.apache.org/r/42888/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 42888: Used absolute paths for excludes paths in
posix disk isolator.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42888/#review116700
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 28, 2016, 1:14 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42888/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 1:14 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
>
>
> Bugs: MESOS-4539
> https://issues.apache.org/jira/browse/MESOS-4539
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used absolute paths for excludes paths in posix disk isolator.
>
> We should consistently use absolute paths for excludes paths in disk isolator, otherwise, it's possible that some other paths under the directory matches the relative path, causing incorrect disk usage being reported.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/posix/disk.hpp 5607c0f43084f491e4927f5c6ec283210aa5f355
> src/slave/containerizer/mesos/isolators/posix/disk.cpp d5bf8c10b9cfb360a7856144d59ce89060de5c99
>
> Diff: https://reviews.apache.org/r/42888/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42888: Used absolute paths for excludes paths in
posix disk isolator.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42888/
-----------------------------------------------------------
(Updated Jan. 28, 2016, 1:14 a.m.)
Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
Bugs: MESOS-4539
https://issues.apache.org/jira/browse/MESOS-4539
Repository: mesos
Description
-------
Used absolute paths for excludes paths in posix disk isolator.
We should consistently use absolute paths for excludes paths in disk isolator, otherwise, it's possible that some other paths under the directory matches the relative path, causing incorrect disk usage being reported.
Diffs
-----
src/slave/containerizer/mesos/isolators/posix/disk.hpp 5607c0f43084f491e4927f5c6ec283210aa5f355
src/slave/containerizer/mesos/isolators/posix/disk.cpp d5bf8c10b9cfb360a7856144d59ce89060de5c99
Diff: https://reviews.apache.org/r/42888/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu