[jira] [Closed] (FLINK-17187) Streamline setting of config options

["Chesnay Schepler (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-17187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chesnay Schepler closed FLINK-17187.
------------------------------------
    Fix Version/s:     (was: 1.11.0)
                   docker-1.9.3.0
                   docker-1.11.0.0
                   docker-1.10.1.0
       Resolution: Fixed

docker-master: 379970e8d2a9e138d1291d83b47e7ea643421b3a

> Streamline setting of config options
> ------------------------------------
>
>                 Key: FLINK-17187
>                 URL: https://issues.apache.org/jira/browse/FLINK-17187
>             Project: Flink
>          Issue Type: Improvement
>          Components: Dockerfiles
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: docker-1.10.1.0, docker-1.11.0.0, docker-1.9.3.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The docker-entrypoint.sh has some verbose sections for setting config options with lots of duplicated logic. We should introduce a utility method for setting config options.
>  
> {code:java}
> if grep -E "^jobmanager\.rpc\.address:.*" "${CONF_FILE}" > /dev/null; then
>     sed -i -e "s/jobmanager\.rpc\.address:.*/jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}/g" "${CONF_FILE}"
> else
>     echo "jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}" >> "${CONF_FILE}"
> fiif grep -E "^blob\.server\.port:.*" "${CONF_FILE}" > /dev/null; then
>     sed -i -e "s/blob\.server\.port:.*/blob.server.port: 6124/g" "${CONF_FILE}"
> else
>     echo "blob.server.port: 6124" >> "${CONF_FILE}"
> fi
> ...{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)