[jira] [Closed] (THRIFT-1679) NodeJS: protocol readString() should treat string as utf8, not binary

["Henrique Mendonca (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henrique Mendonca closed THRIFT-1679.
-------------------------------------

       Resolution: Implemented
    Fix Version/s: 0.9
    
> NodeJS: protocol readString() should treat string as utf8, not binary
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-1679
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1679
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>    Affects Versions: 0.8
>         Environment: All
>            Reporter: Michael Fleming
>             Fix For: 0.9
>
>
> Using Node.js's Thrift library to talk to Hive:
> a) Read back a Hive result that contains utf8 characters
> Expected:
> - Get a Javascript string object that contains the correct utf8 sequence
> Actual:
> - Get a Javascript sequence that is indicative of UTF8 double-encoding
> Underlying:
> In protocol.js, change "readString()"
>  var r = this.readBinary().toString('binary');
> to this:
> var r = this.readBinary().toString('utf8');
> Per http://thrift.apache.org/docs/types/
> "string: A text string encoded using UTF-8 encoding"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira