You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "SaschaJohn (via GitHub)" <gi...@apache.org> on 2026/03/12 18:26:59 UTC
[PR] Update Dockerfile to comment out environment variables [polaris-tools]
SaschaJohn opened a new pull request, #189:
URL: https://github.com/apache/polaris-tools/pull/189
Comment out default environment variables in Dockerfile.
Fixes #188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Dockerfile to comment out environment variables [polaris-tools]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #189:
URL: https://github.com/apache/polaris-tools/pull/189#discussion_r2926643383
##########
console/docker/Dockerfile:
##########
@@ -18,12 +18,12 @@
# Build stage
FROM registry.access.redhat.com/ubi9/nodejs-22-minimal:9.7-1767673763 AS builder
-# Default environment variables (can be overridden at runtime)
-ENV VITE_POLARIS_API_URL=http://polaris:8181
-ENV VITE_POLARIS_REALM=POLARIS
-ENV VITE_POLARIS_PRINCIPAL_SCOPE=PRINCIPAL_ROLE:ALL
-ENV VITE_OAUTH_TOKEN_URL=http://polaris:8181/api/catalog/v1/oauth/tokens
-ENV VITE_POLARIS_REALM_HEADER_NAME=Polaris-Realm
+# Default environment variables required (need to be set at runtime)
+#ENV VITE_POLARIS_API_URL=http://polaris:8181
Review Comment:
The initial purpose here is to have default value that can be overridden.
Are you suggesting to "force" user to define it ? It's a behavioral change here.
##########
console/docker/Dockerfile:
##########
@@ -43,7 +43,7 @@ RUN npm run build
FROM registry.access.redhat.com/ubi9/nginx-126:9.7-1767846422
# Copy DISCLAIMER, LICENSE, NOTICE files
-COPY DISCLAIMER /DISCLAIMER
+#COPY DISCLAIMER /DISCLAIMER
Review Comment:
Good catch 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Dockerfile to comment out environment variables [polaris-tools]
Posted by "SaschaJohn (via GitHub)" <gi...@apache.org>.
SaschaJohn commented on code in PR #189:
URL: https://github.com/apache/polaris-tools/pull/189#discussion_r2926726593
##########
console/docker/Dockerfile:
##########
@@ -18,12 +18,12 @@
# Build stage
FROM registry.access.redhat.com/ubi9/nodejs-22-minimal:9.7-1767673763 AS builder
-# Default environment variables (can be overridden at runtime)
-ENV VITE_POLARIS_API_URL=http://polaris:8181
-ENV VITE_POLARIS_REALM=POLARIS
-ENV VITE_POLARIS_PRINCIPAL_SCOPE=PRINCIPAL_ROLE:ALL
-ENV VITE_OAUTH_TOKEN_URL=http://polaris:8181/api/catalog/v1/oauth/tokens
-ENV VITE_POLARIS_REALM_HEADER_NAME=Polaris-Realm
+# Default environment variables required (need to be set at runtime)
+#ENV VITE_POLARIS_API_URL=http://polaris:8181
Review Comment:
@jbonofre see #188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org