You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/15 23:29:20 UTC
[GitHub] [cordova-fetch] raphinesse opened a new pull request #91: fix: cordova-fetch w/ npm@7
raphinesse opened a new pull request #91:
URL: https://github.com/apache/cordova-fetch/pull/91
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
https://github.com/apache/cordova-lib/issues/859
### Description
<!-- Describe your changes in detail -->
- Changes as outlined in the latest hangout
- Some adjustments to test expectations to handle minor behavior changes in `npm@7`
### Testing
<!-- Please describe in detail how you tested your changes. -->
Included test suite.
### TODO
- Merge #89
- Test with cli & lib
- Add CI test w/ `npm@7`?
- Maybe replace a few of the unit tests I threw out here
- Check if `pacote` and `npm` are sharing a cache as expected. The test duration actually increased from 90s to 110–120s with this fix, so we are actually spending a bit more extra time than expected
- Do something about the two failing expectations
`uninstall` seems to be broken with `--no-save` on `npm@7`. Specifically the sequence
```bash
cd $(mktemp -d)
mkdir node_modules
npm i cordova-android --no-save
npm un cordova-android --no-save
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] raphinesse merged pull request #91: fix: cordova-fetch with npm@7
Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #91:
URL: https://github.com/apache/cordova-fetch/pull/91
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io edited a comment on pull request #91: fix: cordova-fetch with npm@7
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #91:
URL: https://github.com/apache/cordova-fetch/pull/91#issuecomment-709642531
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=h1) Report
> Merging [#91](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=desc) (dace3fc) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/1d96eaed3a966b6f259507230602f3f3c8b40d90?el=desc) (1d96eae) will **increase** coverage by `0.90%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 92.42% 93.33% +0.90%
==========================================
Files 1 1
Lines 66 60 -6
==========================================
- Hits 61 56 -5
+ Misses 5 4 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/91/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `93.33% <100.00%> (+0.90%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=footer). Last update [1d96eae...dace3fc](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io edited a comment on pull request #91: fix: cordova-fetch with npm@7
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #91:
URL: https://github.com/apache/cordova-fetch/pull/91#issuecomment-709642531
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=h1) Report
> Merging [#91](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=desc) (10cc17f) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/1d96eaed3a966b6f259507230602f3f3c8b40d90?el=desc) (1d96eae) will **increase** coverage by `0.90%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 92.42% 93.33% +0.90%
==========================================
Files 1 1
Lines 66 60 -6
==========================================
- Hits 61 56 -5
+ Misses 5 4 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/91/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `93.33% <100.00%> (+0.90%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=footer). Last update [1d96eae...10cc17f](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io edited a comment on pull request #91: fix: cordova-fetch with npm@7
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #91:
URL: https://github.com/apache/cordova-fetch/pull/91#issuecomment-709642531
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=h1) Report
> Merging [#91](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=desc) (10cc17f) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/1d96eaed3a966b6f259507230602f3f3c8b40d90?el=desc) (1d96eae) will **increase** coverage by `0.90%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 92.42% 93.33% +0.90%
==========================================
Files 1 1
Lines 66 60 -6
==========================================
- Hits 61 56 -5
+ Misses 5 4 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/91/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `93.33% <100.00%> (+0.90%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=footer). Last update [1d96eae...10cc17f](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io edited a comment on pull request #91: fix: cordova-fetch w/ npm@7
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #91:
URL: https://github.com/apache/cordova-fetch/pull/91#issuecomment-709642531
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=h1) Report
> Merging [#91](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/1d96eaed3a966b6f259507230602f3f3c8b40d90?el=desc) will **increase** coverage by `0.90%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 92.42% 93.33% +0.90%
==========================================
Files 1 1
Lines 66 60 -6
==========================================
- Hits 61 56 -5
+ Misses 5 4 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/91/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `93.33% <100.00%> (+0.90%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=footer). Last update [1d96eae...362eb29](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io commented on pull request #91: fix: cordova-fetch w/ npm@7
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #91:
URL: https://github.com/apache/cordova-fetch/pull/91#issuecomment-709642531
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=h1) Report
> Merging [#91](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/8dc1fe1685d8fdb39a51017fbf300ba9b57366a5?el=desc) will **increase** coverage by `1.02%`.
> The diff coverage is `92.10%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 92.30% 93.33% +1.02%
==========================================
Files 1 1
Lines 65 60 -5
==========================================
- Hits 60 56 -4
+ Misses 5 4 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/91/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `93.33% <92.10%> (+1.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=footer). Last update [8dc1fe1...8adbf59](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io edited a comment on pull request #91: fix: cordova-fetch with npm@7
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #91:
URL: https://github.com/apache/cordova-fetch/pull/91#issuecomment-709642531
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=h1) Report
> Merging [#91](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=desc) (dace3fc) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/1d96eaed3a966b6f259507230602f3f3c8b40d90?el=desc) (1d96eae) will **increase** coverage by `0.90%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 92.42% 93.33% +0.90%
==========================================
Files 1 1
Lines 66 60 -6
==========================================
- Hits 61 56 -5
+ Misses 5 4 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/91/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `93.33% <100.00%> (+0.90%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=footer). Last update [1d96eae...dace3fc](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io edited a comment on pull request #91: fix: cordova-fetch w/ npm@7
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #91:
URL: https://github.com/apache/cordova-fetch/pull/91#issuecomment-709642531
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=h1) Report
> Merging [#91](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/8dc1fe1685d8fdb39a51017fbf300ba9b57366a5?el=desc) will **increase** coverage by `1.02%`.
> The diff coverage is `92.10%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 92.30% 93.33% +1.02%
==========================================
Files 1 1
Lines 65 60 -5
==========================================
- Hits 60 56 -4
+ Misses 5 4 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/91/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `93.33% <92.10%> (+1.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=footer). Last update [8dc1fe1...8adbf59](https://codecov.io/gh/apache/cordova-fetch/pull/91?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org