You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/03/02 17:13:52 UTC
[GitHub] [hive] pvary opened a new pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
pvary opened a new pull request #3072:
URL: https://github.com/apache/hive/pull/3072
### What changes were proposed in this pull request?
Cleans up deprecated methods
### Why are the changes needed?
We do not want to release deprecated methods
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit tests will show errors, if any
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #3072:
URL: https://github.com/apache/hive/pull/3072#discussion_r818719096
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
##########
@@ -1545,83 +1545,6 @@ GetPartitionsPsWithAuthResponse listPartitionsWithAuthInfoRequest(GetPartitionsP
PartitionsResponse getPartitionsRequest(PartitionsRequest req)
throws NoSuchObjectException, MetaException, TException;
- /**
- * Get partitions by a list of partition names.
- * @param db_name database name
- * @param tbl_name table name
- * @param part_names list of partition names
- * @param getColStats if true include statistics in the Partition object
- * @param engine engine sending the request
- * @return list of Partition objects
- * @throws NoSuchObjectException No such partitionscatName
- * @throws MetaException error accessing the RDBMS.
- * @throws TException thrift transport error
- */
- List<Partition> getPartitionsByNames(String db_name, String tbl_name, List<String> part_names,
- boolean getColStats, String engine) throws NoSuchObjectException, MetaException, TException;
-
- /**
- * Get partitions by a list of partition names.
- * @param catName catalog name
- * @param db_name database name
- * @param tbl_name table name
- * @param part_names list of partition names
- * @return list of Partition objects
- * @throws NoSuchObjectException No such partitions
- * @throws MetaException error accessing the RDBMS.
- * @throws TException thrift transport error
- */
- List<Partition> getPartitionsByNames(String catName, String db_name, String tbl_name,
Review comment:
Thanks for noticing. Added back with depreaction
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
##########
@@ -1545,83 +1545,6 @@ GetPartitionsPsWithAuthResponse listPartitionsWithAuthInfoRequest(GetPartitionsP
PartitionsResponse getPartitionsRequest(PartitionsRequest req)
throws NoSuchObjectException, MetaException, TException;
- /**
- * Get partitions by a list of partition names.
- * @param db_name database name
- * @param tbl_name table name
- * @param part_names list of partition names
- * @param getColStats if true include statistics in the Partition object
- * @param engine engine sending the request
- * @return list of Partition objects
- * @throws NoSuchObjectException No such partitionscatName
- * @throws MetaException error accessing the RDBMS.
- * @throws TException thrift transport error
- */
- List<Partition> getPartitionsByNames(String db_name, String tbl_name, List<String> part_names,
- boolean getColStats, String engine) throws NoSuchObjectException, MetaException, TException;
-
- /**
- * Get partitions by a list of partition names.
- * @param catName catalog name
- * @param db_name database name
- * @param tbl_name table name
- * @param part_names list of partition names
- * @return list of Partition objects
- * @throws NoSuchObjectException No such partitions
- * @throws MetaException error accessing the RDBMS.
- * @throws TException thrift transport error
- */
- List<Partition> getPartitionsByNames(String catName, String db_name, String tbl_name,
Review comment:
Thanks for noticing. Added back with deprecation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary edited a comment on pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
pvary edited a comment on pull request #3072:
URL: https://github.com/apache/hive/pull/3072#issuecomment-1063822321
The ` List<String> listPartitionNames(String catName, String dbName, String tblName, String defaultPartName, byte[] exprBytes, String order, short maxParts) ` method was added by me as part of HIVE-22458.
Currently in master we use `List<String> listPartitionNames(PartitionsByExprRequest request)` to replace others with the same method name, so I think the method can also be cleaned...
Sorry for that...
> IMetaStoreClient `listPartitionNames` at line 1309 can be cleaned, it would be great if you can do me a favor for that.
> Thanks,
> Zhihua Deng
Could you please ellaborate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #3072:
URL: https://github.com/apache/hive/pull/3072#discussion_r818720096
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
##########
@@ -1639,21 +1562,6 @@ PartitionsResponse getPartitionsRequest(PartitionsRequest req)
boolean getColStats, String engine, String validWriteIdList, Long tableId)
throws TException;
Review comment:
That was a tougher nut, but I hope I was successful 😄
Let's see the test results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #3072:
URL: https://github.com/apache/hive/pull/3072#discussion_r818575852
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
##########
@@ -1639,21 +1562,6 @@ PartitionsResponse getPartitionsRequest(PartitionsRequest req)
boolean getColStats, String engine, String validWriteIdList, Long tableId)
throws TException;
Review comment:
This method(line:1638) seems can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #3072:
URL: https://github.com/apache/hive/pull/3072#issuecomment-1063573484
> @dengzhhu653, @zabetak: Could you please review? Thanks, Peter
Look good to me, +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #3072:
URL: https://github.com/apache/hive/pull/3072#discussion_r818573704
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
##########
@@ -1545,83 +1545,6 @@ GetPartitionsPsWithAuthResponse listPartitionsWithAuthInfoRequest(GetPartitionsP
PartitionsResponse getPartitionsRequest(PartitionsRequest req)
throws NoSuchObjectException, MetaException, TException;
- /**
- * Get partitions by a list of partition names.
- * @param db_name database name
- * @param tbl_name table name
- * @param part_names list of partition names
- * @param getColStats if true include statistics in the Partition object
- * @param engine engine sending the request
- * @return list of Partition objects
- * @throws NoSuchObjectException No such partitionscatName
- * @throws MetaException error accessing the RDBMS.
- * @throws TException thrift transport error
- */
- List<Partition> getPartitionsByNames(String db_name, String tbl_name, List<String> part_names,
- boolean getColStats, String engine) throws NoSuchObjectException, MetaException, TException;
-
- /**
- * Get partitions by a list of partition names.
- * @param catName catalog name
- * @param db_name database name
- * @param tbl_name table name
- * @param part_names list of partition names
- * @return list of Partition objects
- * @throws NoSuchObjectException No such partitions
- * @throws MetaException error accessing the RDBMS.
- * @throws TException thrift transport error
- */
- List<Partition> getPartitionsByNames(String catName, String db_name, String tbl_name,
Review comment:
Seems this method is released from version 3.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #3072:
URL: https://github.com/apache/hive/pull/3072#issuecomment-1059674601
Overall looks good to me, +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #3072:
URL: https://github.com/apache/hive/pull/3072#issuecomment-1063587762
> > @dengzhhu653, @zabetak: Could you please review? Thanks, Peter
>
> Look good to me, +1
IMetaStoreClient `listPartitionNames` at line 1309 can be cleaned, it would be great if you can do me a favor for that.
Thanks,
Zhihua Deng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #3072:
URL: https://github.com/apache/hive/pull/3072#discussion_r822331248
##########
File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestStats.java
##########
@@ -291,7 +285,6 @@ public void tableInHiveCatalog() throws TException {
dropStats(DEFAULT_CATALOG_NAME, dbName, tableName, null, colMap.keySet());
}
- @Ignore("HIVE-19509: Disable tests that are failing continuously")
@Test
Review comment:
Maybe all 3. Will do it when I have some time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #3072:
URL: https://github.com/apache/hive/pull/3072#issuecomment-1063849177
The ` List<String> listPartitionNames(String catName, String dbName, String tblName, String defaultPartName, byte[] exprBytes, String order, short maxParts) ` method was added by me as part of HIVE-22458.
Currently in master we use `List<String> listPartitionNames(PartitionsByExprRequest request)` to replace others with the same method name, so I think the method can also be cleaned...
Sorry about that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #3072:
URL: https://github.com/apache/hive/pull/3072#issuecomment-1063865317
> The `List<String> listPartitionNames(String catName, String dbName, String tblName, String defaultPartName, byte[] exprBytes, String order, short maxParts)` method was added by me as part of [HIVE-22458](https://issues.apache.org/jira/browse/HIVE-22458). Currently in master we use `List<String> listPartitionNames(PartitionsByExprRequest request)` to replace others with the same method name, so I think the method can also be cleaned...
Created https://issues.apache.org/jira/browse/HIVE-26025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #3072:
URL: https://github.com/apache/hive/pull/3072#issuecomment-1062866042
@dengzhhu653, @zabetak: Could you please review?
Thanks,
Peter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary edited a comment on pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
pvary edited a comment on pull request #3072:
URL: https://github.com/apache/hive/pull/3072#issuecomment-1063822321
> IMetaStoreClient `listPartitionNames` at line 1309 can be cleaned, it would be great if you can do me a favor for that.
> Thanks,
> Zhihua Deng
Could you please ellaborate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #3072:
URL: https://github.com/apache/hive/pull/3072#discussion_r822236501
##########
File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestStats.java
##########
@@ -291,7 +285,6 @@ public void tableInHiveCatalog() throws TException {
dropStats(DEFAULT_CATALOG_NAME, dbName, tableName, null, colMap.keySet());
}
- @Ignore("HIVE-19509: Disable tests that are failing continuously")
@Test
Review comment:
maybe we should also disable this method...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #3072:
URL: https://github.com/apache/hive/pull/3072#issuecomment-1063822321
> IMetaStoreClient `listPartitionNames` at line 1309 can be cleaned, it would be great if you can do me a favor for that.
> Thanks,
> Zhihua Deng
Could you please ellaborate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #3072:
URL: https://github.com/apache/hive/pull/3072#discussion_r820594561
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -4151,16 +4152,18 @@ public boolean dropPartition(String dbName, String tableName, List<String> parti
}
if (nParts > nBatches * batchSize) {
- String validWriteIdList = null;
- Long tableId = null;
- if (AcidUtils.isTransactionalTable(tbl)) {
- ValidWriteIdList vWriteIdList = getValidWriteIdList(tbl.getDbName(), tbl.getTableName());
- validWriteIdList = vWriteIdList != null ? vWriteIdList.toString() : null;
- tableId = tbl.getTTable().getId();
- }
+ String validWriteIdList = null;
Review comment:
We need to push down the `vaildWriteIdList` and the `tableId`, so if there is caching in the catalog side then we the cache could be refreshed when needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary merged pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
pvary merged pull request #3072:
URL: https://github.com/apache/hive/pull/3072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #3072:
URL: https://github.com/apache/hive/pull/3072#discussion_r820021805
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -4151,16 +4152,18 @@ public boolean dropPartition(String dbName, String tableName, List<String> parti
}
if (nParts > nBatches * batchSize) {
- String validWriteIdList = null;
- Long tableId = null;
- if (AcidUtils.isTransactionalTable(tbl)) {
- ValidWriteIdList vWriteIdList = getValidWriteIdList(tbl.getDbName(), tbl.getTableName());
- validWriteIdList = vWriteIdList != null ? vWriteIdList.toString() : null;
- tableId = tbl.getTTable().getId();
- }
+ String validWriteIdList = null;
Review comment:
nit: I wonder if we can use the following:
```java
GetPartitionsByNamesRequest req = MetaStoreUtils.convertToGetPartitionsByNamesRequest(tbl.getDbName(), tbl.getTableName(),
partNames.subList(nBatches*batchSize, nParts), getColStats, Constants.HIVE_ENGINE, null,
null);
List<org.apache.hadoop.hive.metastore.api.Partition> tParts = getPartitionsByNames(req, tbl);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #3072: HIVE-25935: Cleanup IMetaStoreClient#getPartitionsByNames APIs
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #3072:
URL: https://github.com/apache/hive/pull/3072#discussion_r818573704
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
##########
@@ -1545,83 +1545,6 @@ GetPartitionsPsWithAuthResponse listPartitionsWithAuthInfoRequest(GetPartitionsP
PartitionsResponse getPartitionsRequest(PartitionsRequest req)
throws NoSuchObjectException, MetaException, TException;
- /**
- * Get partitions by a list of partition names.
- * @param db_name database name
- * @param tbl_name table name
- * @param part_names list of partition names
- * @param getColStats if true include statistics in the Partition object
- * @param engine engine sending the request
- * @return list of Partition objects
- * @throws NoSuchObjectException No such partitionscatName
- * @throws MetaException error accessing the RDBMS.
- * @throws TException thrift transport error
- */
- List<Partition> getPartitionsByNames(String db_name, String tbl_name, List<String> part_names,
- boolean getColStats, String engine) throws NoSuchObjectException, MetaException, TException;
-
- /**
- * Get partitions by a list of partition names.
- * @param catName catalog name
- * @param db_name database name
- * @param tbl_name table name
- * @param part_names list of partition names
- * @return list of Partition objects
- * @throws NoSuchObjectException No such partitions
- * @throws MetaException error accessing the RDBMS.
- * @throws TException thrift transport error
- */
- List<Partition> getPartitionsByNames(String catName, String db_name, String tbl_name,
Review comment:
Seems this method is realeased from version 3.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org