You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Amarjeet Singh (JIRA)" <ji...@apache.org> on 2018/03/05 06:34:00 UTC

[jira] [Commented] (GUACAMOLE-473) Automatically rename uploaded file if destination file already exists

    [ https://issues.apache.org/jira/browse/GUACAMOLE-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385653#comment-16385653 ] 

Amarjeet Singh commented on GUACAMOLE-473:
------------------------------------------

Hi Mike,

{quote}When uploading files through some file transfer mechanism, I would normally expect that file to be uploaded without being renamed, replacing the existing remote file if necessary. Ideally, prompting before overwriting would be an improvement, but magically and silently renaming the uploaded file seems to me to violate the principle of least surprise.{quote}

If files with the same name already exist in the shared drive, then it uploads the files without any prompt. 
It should *at least ask for the user's permission before overwriting* any file and it is a expected behaviour. This behaviour is implemented everywhere where we use to upload the files.
Hence, Guacamole should also ask user's permission before overwriting the file.
{quote}I fully agree with you that silently overwriting the file probably needs to be addresses{quote}
It need to be addressed.

> Automatically rename uploaded file if destination file already exists
> ---------------------------------------------------------------------
>
>                 Key: GUACAMOLE-473
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-473
>             Project: Guacamole
>          Issue Type: Wish
>          Components: RDP
>            Reporter: Amarjeet Singh
>            Priority: Trivial
>
> While uploading file which already exists in the shared drive it doesn't  include 1 or 2 in suffix instead it overwrite the existing file in the shared drive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)