You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/27 21:35:32 UTC

[GitHub] [arrow] wesm opened a new pull request #7557: ARROW-9251: [C++] Relocate integration testing JSON code implementation to src/arrow/testing

wesm opened a new pull request #7557:
URL: https://github.com/apache/arrow/pull/7557


   While this code is not being shipped in any packages, I think it would be better for it to live in the testing directory so that its purpose is clear
   
   I think there may be potentially some value in exposing `ArrayFromJSON` (in ipc/json_simple.h) in bindings at some point so I have left this code where it is, though it might be better to move it to arrow/json


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7557: ARROW-9251: [C++] Relocate integration testing JSON code implementation to src/arrow/testing

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7557:
URL: https://github.com/apache/arrow/pull/7557#issuecomment-650634874


   https://issues.apache.org/jira/browse/ARROW-9251


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] wesm commented on pull request #7557: ARROW-9251: [C++] Relocate integration testing JSON code implementation to src/arrow/testing

Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7557:
URL: https://github.com/apache/arrow/pull/7557#issuecomment-650866076


   +1. The ASAN/UBSAN failure is fixed by https://github.com/apache/arrow/pull/7575


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] wesm closed pull request #7557: ARROW-9251: [C++] Relocate integration testing JSON code implementation to src/arrow/testing

Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7557:
URL: https://github.com/apache/arrow/pull/7557


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org