You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xerces.apache.org by mu...@apache.org on 2010/05/16 10:29:08 UTC

svn commit: r944773 - /xerces/java/trunk/samples/sax/Counter.java

Author: mukulg
Date: Sun May 16 08:29:07 2010
New Revision: 944773

URL: http://svn.apache.org/viewvc?rev=944773&view=rev
Log:
there is a possible null pointer dereference at, ex.getSystemId(). this commit solves this, issue.

Modified:
    xerces/java/trunk/samples/sax/Counter.java

Modified: xerces/java/trunk/samples/sax/Counter.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/samples/sax/Counter.java?rev=944773&r1=944772&r2=944773&view=diff
==============================================================================
--- xerces/java/trunk/samples/sax/Counter.java (original)
+++ xerces/java/trunk/samples/sax/Counter.java Sun May 16 08:29:07 2010
@@ -317,24 +317,26 @@ public class Counter
         System.err.print("[");
         System.err.print(type);
         System.err.print("] ");
-        if (ex== null) {
+        if (ex == null) {
             System.out.println("!!!");
         }
-        String systemId = ex.getSystemId();
-        if (systemId != null) {
-            int index = systemId.lastIndexOf('/');
-            if (index != -1)
-                systemId = systemId.substring(index + 1);
-            System.err.print(systemId);
+        else {
+            String systemId = ex.getSystemId();
+            if (systemId != null) {
+                int index = systemId.lastIndexOf('/');
+                if (index != -1)
+                    systemId = systemId.substring(index + 1);
+                System.err.print(systemId);
+            }
+            System.err.print(':');
+            System.err.print(ex.getLineNumber());
+            System.err.print(':');
+            System.err.print(ex.getColumnNumber());
+            System.err.print(": ");
+            System.err.print(ex.getMessage());
+            System.err.println();
+            System.err.flush();
         }
-        System.err.print(':');
-        System.err.print(ex.getLineNumber());
-        System.err.print(':');
-        System.err.print(ex.getColumnNumber());
-        System.err.print(": ");
-        System.err.print(ex.getMessage());
-        System.err.println();
-        System.err.flush();
 
     } // printError(String,SAXParseException)
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org