You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Aleksey Shipilev (JIRA)" <ji...@apache.org> on 2008/04/14 14:51:06 UTC

[jira] Created: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream can use Reflection API for setting fields

[classlib][luni][performance] ObjectInputStream can use Reflection API for setting fields
-----------------------------------------------------------------------------------------

                 Key: HARMONY-5722
                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
             Project: Harmony
          Issue Type: Improvement
            Reporter: Aleksey Shipilev


For now, OIS.readFieldValues uses JNI for accessing fields. It's bad for several reasons:
 a. infers a lot of JNI calls
 b. creates a lot of strings when looking up the field id.

This issue moves setField functionality to Reflection API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Attachment: cl-OIS_OOS-accessors-rc2.patch

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-accessors-rc2.patch, cl-OIS_OOS-accessors-rc2.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Issue Type: Sub-task  (was: Improvement)
        Parent: HARMONY-5632

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>             Fix For: 5.0M6
>
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-accessors-rc2.patch, cl-OIS_OOS-accessors-rc3.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588807#action_12588807 ] 

Aleksey Shipilev commented on HARMONY-5722:
-------------------------------------------

cl-OIS_OOS-accessors-rc1.patch gives:
 30% boost on 2-core Core2Duo
 35% boost on 8-core Core2Duo (Clovertown)
 120% boost on 16-core Core2Duo (Tigerton)

for MT/SerialBench.

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Attachment:     (was: cl-OIS_OOS-accessors-rc2.patch)

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-accessors-rc2.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589016#action_12589016 ] 

Alexey Varlamov commented on HARMONY-5722:
------------------------------------------

The patch needs certain clean-up before integration:
1) Mods of ObjectAccessor are not valid, they create evident security breach. Please use AccessorFactory instead.
2) Please remove empty native sources after eliminating native methods;
3) Drop debug comments from ObjectStreamField

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Attachment: cl-OIS_OOS-accessors-rc2.patch

cl-OIS_OOS-accessors-rc2.patch
Changes:
 1. Fixed failures on LUNI unit-tests
 2. Cleaned up ObjectStreamField
 3. AccessorFactory is used

Tony, please use this patch.
Alexei, thanks for the comments!

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-accessors-rc2.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use Reflection API for setting/getting fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Attachment: cl-OIS_OOS-reflection-rc1.patch

cl-OIS_OOS-reflection-rc1.patch
 a. Moving OIS and OOS field accessors to Reflection API
 b. Cleaning up native method table
 c. Aggregating Field cache in ObjectStreamField, cleaning up Field access schemes


> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use Reflection API for setting/getting fields
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to Reflection API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream can use Reflection API for setting fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588578#action_12588578 ] 

Aleksey Shipilev commented on HARMONY-5722:
-------------------------------------------

Next: moving OOS to Reflection API.

> [classlib][luni][performance] ObjectInputStream can use Reflection API for setting fields
> -----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>            Reporter: Aleksey Shipilev
>         Attachments: cl-ois-readfieldvalues-rc1.patch
>
>
> For now, OIS.readFieldValues uses JNI for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField functionality to Reflection API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tony Wu reassigned HARMONY-5722:
--------------------------------

    Assignee: Tony Wu

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Attachment: cl-OIS_OOS-accessors-rc2.patch

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-accessors-rc2.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use Reflection API for setting/getting fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Description: 
For now, OIS and OOS use JNI for accessing fields. It's bad for several reasons:
 a. infers a lot of JNI calls
 b. creates a lot of strings when looking up the field id.

This issue moves setField/getField functionality to Reflection API.

  was:
For now, OIS.readFieldValues uses JNI for accessing fields. It's bad for several reasons:
 a. infers a lot of JNI calls
 b. creates a lot of strings when looking up the field id.

This issue moves setField functionality to Reflection API.


> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use Reflection API for setting/getting fields
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>         Attachments: cl-ois-readfieldvalues-rc1.patch
>
>
> For now, OIS and OOS use JNI for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to Reflection API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Attachment: cl-OIS_OOS-accessors-rc1.patch

cl-OIS_OOS-accessors-rc1.patch
 1. Implements setField/getField via accessors, benefit is, security check only once during accessor initialization
 2. Caches jFieldID in ObjectStreamField.

Gives astonishing +30% boost on 2-core Core2Duo with 2 threads on MT/SerialBench.
8- and 16- thread measurements are due.

This patch is presumably safe and might be committed in this form.

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use Reflection API for setting/getting fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Component/s: Classlib
        Summary: [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use Reflection API for setting/getting fields  (was: [classlib][luni][performance] ObjectInputStream can use Reflection API for setting fields)

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use Reflection API for setting/getting fields
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>         Attachments: cl-ois-readfieldvalues-rc1.patch
>
>
> For now, OIS.readFieldValues uses JNI for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField functionality to Reflection API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tony Wu resolved HARMONY-5722.
------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M6

Hi, Aleksey

patch-rc3 applied at r648977. I removed the oos.c, modified the makefiles, and the manifest file in order to maintain the plug-in dependency.
Thanks for your contribution, please verify if it fixed as you expected.

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>             Fix For: 5.0M6
>
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-accessors-rc2.patch, cl-OIS_OOS-accessors-rc3.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream can use Reflection API for setting fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Attachment: cl-ois-readfieldvalues-rc1.patch

cl-ois-readfieldvalues-rc1.patch
 1. Moves setField to Reflection API
 2. Caches the j.l.r.Field in ObjectStreamField.

This patch gives +20% on 8-core Clovertown and +110% on 16-core Tigerton for MT/SerialBench.


> [classlib][luni][performance] ObjectInputStream can use Reflection API for setting fields
> -----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>            Reporter: Aleksey Shipilev
>         Attachments: cl-ois-readfieldvalues-rc1.patch
>
>
> For now, OIS.readFieldValues uses JNI for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField functionality to Reflection API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589512#action_12589512 ] 

Tony Wu commented on HARMONY-5722:
----------------------------------

Aleksey,
some serialization test in  auth module such as javax.security.auth.SubjectTest fails with patch-rc2

Wrong format: 0x0

java.io.StreamCorruptedException: Wrong format: 0x0 at java.io.ObjectInputStream.readNonPrimitiveContent(ObjectInputStream.java:849) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:2133) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:288) at 

and as Alexey said, we should remove the empty source file oos.c

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-accessors-rc2.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev closed HARMONY-5722.
-------------------------------------


Verified.
Thanks, Tony.

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>             Fix For: 5.0M6
>
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-accessors-rc2.patch, cl-OIS_OOS-accessors-rc3.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use Reflection API for setting/getting fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588642#action_12588642 ] 

Aleksey Shipilev commented on HARMONY-5722:
-------------------------------------------

The boost is floating. I will try to rewrite the issue on accessors rather than Reflection API.

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use Reflection API for setting/getting fields
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to Reflection API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Attachment: cl-OIS_OOS-accessors-rc3.patch

cl-OIS_OOS-accessors-rc3.patch
Fixed failures on all serialization-related unit tests.

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>            Assignee: Tony Wu
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-accessors-rc1.patch, cl-OIS_OOS-accessors-rc2.patch, cl-OIS_OOS-accessors-rc3.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5722) [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5722:
--------------------------------------

    Description: 
For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
 a. infers a lot of JNI calls
 b. creates a lot of strings when looking up the field id.

This issue moves setField/getField functionality to more optimized API.

  was:
For now, OIS and OOS use JNI for accessing fields. It's bad for several reasons:
 a. infers a lot of JNI calls
 b. creates a lot of strings when looking up the field id.

This issue moves setField/getField functionality to Reflection API.

        Summary: [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields  (was: [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use Reflection API for setting/getting fields)

> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream can use optimized API for accessing fields
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5722
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5722
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Aleksey Shipilev
>         Attachments: cl-ois-readfieldvalues-rc1.patch, cl-OIS_OOS-reflection-rc1.patch
>
>
> For now, OIS and OOS use JNI stubs for accessing fields. It's bad for several reasons:
>  a. infers a lot of JNI calls
>  b. creates a lot of strings when looking up the field id.
> This issue moves setField/getField functionality to more optimized API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.