You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/26 16:34:18 UTC

[GitHub] [airflow] jpyen opened a new pull request #16095: Bug Pod Template File Values Ignored

jpyen opened a new pull request #16095:
URL: https://github.com/apache/airflow/pull/16095


   These seem to be the remaining values which are forcefully ignored when set by a pod-template, due to their default values in the constructor. Furthermore I do not see the value of a "test_image_pull_policy_not_set" test or feature, since k8s already provides a default value for image_pull_policy.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-853705594


   `main` branch :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jpyen commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jpyen commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-849105574


   @jedcunningham Any idea why the check is failing? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-849523420


   CI test is failing: https://github.com/apache/airflow/pull/16095/checks?check_run_id=2682561385#step:8:2819


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-849107903


   Not sure. Lets run CI again and see if it goes green 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-849145460


   @jpyen, got further. Looks like the k8s integration tests are failing now.
   
   (btw, if a CI failure is ever puzzling, you can rerun it by rebasing on master or closing/reopening the PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#discussion_r640121008



##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -196,15 +196,15 @@ def __init__(  # pylint: disable=too-many-arguments,too-many-locals
         reattach_on_restart: bool = True,
         startup_timeout_seconds: int = 120,
         get_logs: bool = True,
-        image_pull_policy: str = 'IfNotPresent',
+        image_pull_policy: Optional[str] = None,

Review comment:
       Can you add this change to https://github.com/apache/airflow/blob/master/airflow/providers/cncf/kubernetes/CHANGELOG.rst please




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-850628819


   :( we have merge conflicts, can you rebase on latest master please @jpyen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-853705594


   `main` branch :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jpyen commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jpyen commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-852619866


   Unclear to me why build docks is failing, probably related to my master-rebase?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jpyen commented on a change in pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jpyen commented on a change in pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#discussion_r641007018



##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -19,6 +19,15 @@
 Changelog
 ---------
 
+
+1.2.1
+.....
+
+Bug Fixes
+~~~~~~~~~
+
+* ``Remove image_pull_policy "IfNotPresent" preset, will default to k8s "Always" if not set (#15388)``

Review comment:
       Yes, thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jpyen closed pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jpyen closed pull request #16095:
URL: https://github.com/apache/airflow/pull/16095


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jpyen commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jpyen commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-852261017


   @kaxil Thanks, rebased from master. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #16095:
URL: https://github.com/apache/airflow/pull/16095


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jpyen edited a comment on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jpyen edited a comment on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-852619866


   Unclear to me why build docs is failing, probably related to my master-rebase?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #16095:
URL: https://github.com/apache/airflow/pull/16095


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-849906802


   > All checks passed. By the way, why are there two seperate k8s test suites one in `/tests/proivders/cncf/kubernetes` the other in `/kubernetes_tests/` ?
   
   cncf.kubernetes are unit tests for the provider, tests_kubernetes are test are integration tests with actual K8S instance and running airflow with helm chart.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jpyen commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jpyen commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-853396664


   Rebase to latest master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jpyen commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jpyen commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-853396664


   Rebase to latest master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on a change in pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#discussion_r640935707



##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -19,6 +19,15 @@
 Changelog
 ---------
 
+
+1.2.1
+.....
+
+Bug Fixes
+~~~~~~~~~
+
+* ``Remove image_pull_policy "IfNotPresent" preset, will default to k8s "Always" if not set (#15388)``

Review comment:
       ```suggestion
   * ``Remove image_pull_policy "IfNotPresent" default as k8s already defaults to `Always` if :latest tag is specified, or `IfNotPresent` otherwise (#15388)``
   * ``Remove service_account_name "default" default as k8s already defaults to `default` if not set (#15388)``
   ```
   
   Feel free to adjust, but I think we should describe both removals.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jpyen commented on pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jpyen commented on pull request #16095:
URL: https://github.com/apache/airflow/pull/16095#issuecomment-849896936


   All checks passed. By the way, why are there two seperate k8s test suites one in `/tests/proivders/cncf/kubernetes` the other in `/kubernetes_tests/` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham closed pull request #16095: Bug Pod Template File Values Ignored

Posted by GitBox <gi...@apache.org>.
jedcunningham closed pull request #16095:
URL: https://github.com/apache/airflow/pull/16095


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org