You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by FastWhiteCat <gi...@git.apache.org> on 2014/02/28 11:05:03 UTC
[GitHub] incubator-storm pull request: httpclient version changed from 4.1....
GitHub user FastWhiteCat opened a pull request:
https://github.com/apache/incubator-storm/pull/40
httpclient version changed from 4.1.1 to 4.2.5
I changed httpclient version from 4.1.1 to 4.2.5 in order to make storm working with topologies utilizing the newest version of amazon SDK.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/FastWhiteCat/incubator-storm httpclient425
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit 084ee21786df3d1783a30d9b77ab12639665c3f9
Author: Lukasz Barbuzinski <lu...@fastwhitecat.com>
Date: 2014-02-28T08:30:52Z
httpclient version changed from 4.1.1 to 4.2.5
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: httpclient version changed from 4.1....
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/40#issuecomment-45949463
@FastWhiteCat, would you close this pull request? See #68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: httpclient version changed from 4.1....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: httpclient version changed from 4.1....
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/40#issuecomment-41413483
@FastWhiteCat the http-client has been upgraded to 4.3.3 in the master branch. Would you mind closing this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: httpclient version changed from 4.1....
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/40#issuecomment-36758806
I am OK with the upgrade too. Please file a JIRA for this, and include it in the title of the pull request so that they are linked. I would prefer it if we could shade httpclient, but I am not really sure how we would go about doing that as it is a dependency of a dependency, and not something that storm seems to use directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: httpclient version changed from 4.1....
Posted by drbobbeaty <gi...@git.apache.org>.
Github user drbobbeaty commented on the pull request:
https://github.com/apache/incubator-storm/pull/40#issuecomment-36525963
I'd love to see it moved all the way to 4.3.2 - if possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---