You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Geoffrey De Smet (JIRA)" <ji...@codehaus.org> on 2012/02/09 12:09:02 UTC
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Geoffrey De Smet created MENFORCER-128:
------------------------------------------
Summary: Fail the build if a dependency is overwriten with an incompatible lower version (patch)
Key: MENFORCER-128
URL: https://jira.codehaus.org/browse/MENFORCER-128
Project: Maven 2.x Enforcer Plugin
Issue Type: New Feature
Components: Standard Rules
Reporter: Geoffrey De Smet
Priority: Critical
Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
For example, this is bad:
{code}
<dependencies>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.4.0</version>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>0.9.9</version>
<!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
</dependency>
</dependencies>
{code}
Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291493#comment-291493 ]
Paul Gier commented on MENFORCER-128:
-------------------------------------
The reason I didn't go with something like RequireHighestDependencyVersion is because it sounds like it will require the highest version available in the repository. Upper bound makes more sense to me because what you are saying is that the version in the POM is the highest version that is acceptable in the dependency tree.
Anyway, I think as long at the description in the site docs are good, users will be able to figure out what it means.
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier closed MENFORCER-128.
-------------------------------
Resolution: Fixed
Updated goal name in [r1243269|http://svn.apache.org/viewvc?view=revision&revision=1243269] and [r1243270|http://svn.apache.org/viewvc?view=revision&revision=1243270]
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier reopened MENFORCER-128:
---------------------------------
I agree the goal name could be more clear. How about {{RequireUpperBoundDeps}}? Since other standard rules use "Require" instead of "Force".
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier closed MENFORCER-128.
-------------------------------
Resolution: Fixed
Patch applied in [r1242799|http://svn.apache.org/viewvc?view=revision&revision=1242799], thanks!
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Geoffrey De Smet (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291270#comment-291270 ]
Geoffrey De Smet commented on MENFORCER-128:
--------------------------------------------
Patch includes documentation and IT tests.
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Priority: Critical
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291356#comment-291356 ]
Robert Scholte commented on MENFORCER-128:
------------------------------------------
This new rule is called {{IncompatibleDependencyOverwrite}}, but I don't think that reflects the real purpose. A lower version can still be compatible. This rule is actually checking if it is using the highest of all defined versions per dependency. IMO something like {{ForceHighestDependencyVersion}} or {{ForceUpperBoundDependency}} would be a better name. WDYT?
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier updated MENFORCER-128:
--------------------------------
Fix Version/s: 1.1
Assignee: Paul Gier
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Geoffrey De Smet (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291344#comment-291344 ]
Geoffrey De Smet commented on MENFORCER-128:
--------------------------------------------
To see what sort of dirt this can bring to the surface in a big project, see this issue:
https://issues.jboss.org/browse/JBRULES-3382
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Geoffrey De Smet (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291455#comment-291455 ]
Geoffrey De Smet edited comment on MENFORCER-128 at 2/13/12 2:49 AM:
---------------------------------------------------------------------
I am ok with any name change,
but I do think that "RequireHighestDependencyVersion" is simpler and clearer then "RequireUpperBoundDependencies".
The term "Upper bound" might not be standard knowledge for the average programmer: http://en.wikipedia.org/wiki/Upper_and_lower_bounds
was (Author: ge0ffrey):
I am ok with any name change,
but I do think that "RequireHighestDependencyVersion" is simpler and clearer then "RequireUpperBoundDependencies".
The term "Upper bound" might be misleading and not standard knowledge for the average programmer: http://en.wikipedia.org/wiki/Upper_and_lower_bounds
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Geoffrey De Smet (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291499#comment-291499 ]
Geoffrey De Smet commented on MENFORCER-128:
--------------------------------------------
Ok, sounds good :)
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291376#comment-291376 ]
Robert Scholte commented on MENFORCER-128:
------------------------------------------
You have my +1 for {{RequireUpperBoundDeps}}. I noticed Deps is already used for {{requireReleaseDeps}}, so that should be fine.
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291550#comment-291550 ]
Paul Gier commented on MENFORCER-128:
-------------------------------------
I added a bit more description to the site docs, just to try to make this clear.
[r1243555|http://svn.apache.org/viewvc?view=revision&revision=1243555]
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Geoffrey De Smet (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Geoffrey De Smet updated MENFORCER-128:
---------------------------------------
Attachment: MENFORCER-128.patch
Patch attached.
Please apply on this codebase:
http://svn.apache.org/repos/asf/maven/enforcer/trunk/
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Priority: Critical
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Geoffrey De Smet (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291455#comment-291455 ]
Geoffrey De Smet commented on MENFORCER-128:
--------------------------------------------
I am ok with any name change,
but I do think that "RequireHighestDependencyVersion" is simpler and clearer then "RequireUpperBoundDependencies".
The term "Upper bound" is misleading and not standard knowledge for the average programmer: http://en.wikipedia.org/wiki/Upper_and_lower_bounds
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MENFORCER-128) Fail the build if a dependency is overwriten
with an incompatible lower version (patch)
Posted by "Geoffrey De Smet (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MENFORCER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291455#comment-291455 ]
Geoffrey De Smet edited comment on MENFORCER-128 at 2/13/12 2:48 AM:
---------------------------------------------------------------------
I am ok with any name change,
but I do think that "RequireHighestDependencyVersion" is simpler and clearer then "RequireUpperBoundDependencies".
The term "Upper bound" might be misleading and not standard knowledge for the average programmer: http://en.wikipedia.org/wiki/Upper_and_lower_bounds
was (Author: ge0ffrey):
I am ok with any name change,
but I do think that "RequireHighestDependencyVersion" is simpler and clearer then "RequireUpperBoundDependencies".
The term "Upper bound" is misleading and not standard knowledge for the average programmer: http://en.wikipedia.org/wiki/Upper_and_lower_bounds
> Fail the build if a dependency is overwriten with an incompatible lower version (patch)
> ---------------------------------------------------------------------------------------
>
> Key: MENFORCER-128
> URL: https://jira.codehaus.org/browse/MENFORCER-128
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
> Reporter: Geoffrey De Smet
> Assignee: Paul Gier
> Priority: Critical
> Fix For: 1.1
>
> Attachments: MENFORCER-128.patch
>
>
> Overwriting a dependency to a lower version than any of your other dependencies need should fail the build if this new enforcer rule is active.
> For example, this is bad:
> {code}
> <dependencies>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-api</artifactId>
> <version>1.4.0</version>
> </dependency>
> <dependency>
> <groupId>ch.qos.logback</groupId>
> <artifactId>logback-classic</artifactId>
> <version>0.9.9</version>
> <!-- Depends on org.slf4j:slf4j-api:1.5.0 -->
> </dependency>
> </dependencies>
> {code}
> Attaching patch in a few minutes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira