You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/08 09:16:15 UTC
[GitHub] [zookeeper] iamgd67 opened a new pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex too for easy match to jmx session
iamgd67 opened a new pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813
zooinspector now show "Ephemeral Owner" in 10 base number while JMX connections show in hex format. this makes it a little hard to match them.
It will be much better if hex format is shown too, I will create a pr add hex format just beside the 10 based one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex for easy match to jmx session
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813#issuecomment-1081667315
merged to master, thanks for the contribution and for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] iamgd67 commented on pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex for easy match to jmx session
Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813#issuecomment-1080153355
ping @maoling @symat for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex too for easy match to jmx session
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813#issuecomment-1059069682
@iamgd67
In the context of zk, we present the `zxid` and `sessionId` with hex. IMO, changing the value of '`Ephemeran Owner'` value to hex is good enough. Don't need to add another `JTextField` which makes the UI unsightly and will have render issue in the different platform
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] iamgd67 commented on pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex too for easy match to jmx session
Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813#issuecomment-1064800096
@maoling I will change the pr/Jira title and the code, thanks for your review and opinion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex for easy match to jmx session
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813#issuecomment-1081662847
I'm merging it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex for easy match to jmx session
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] iamgd67 commented on pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex too for easy match to jmx session
Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813#issuecomment-1032410523
this pr add this part to zooinspector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] iamgd67 commented on pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex for easy match to jmx session
Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813#issuecomment-1064810114
as @maoling advised, just use hex format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] iamgd67 commented on pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex for easy match to jmx session
Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813#issuecomment-1064843948
failed test should be unrelated
`QuorumPeerMainTest.testLeaderOutOfView:904 Corrupt peer should join quorum with servers having same server configuration ==> expected: <true> but was: <false>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] iamgd67 commented on pull request #1813: ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex too for easy match to jmx session
Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1813:
URL: https://github.com/apache/zookeeper/pull/1813#issuecomment-1033220078
link to JIRA [ZOOKEEPER-4464](https://issues.apache.org/jira/browse/ZOOKEEPER-4464)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org