You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/02/12 20:22:36 UTC
[GitHub] [groovy] serandel opened a new pull request #1488: Make Gradle build fully cacheable
serandel opened a new pull request #1488:
URL: https://github.com/apache/groovy/pull/1488
As a new hire in Gradle, part of my onboarding has been updating the build of an OSS project to be fully cacheable and we've chosen Groovy for this purpose. Also, the Gradle wrapper and the Gradle Enterprise plug-in have been upgraded to the latest released version.
Please, have a look at my proposed changes, and merge them if you agree with them. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on pull request #1488: Make Gradle build fully cacheable
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1488:
URL: https://github.com/apache/groovy/pull/1488#issuecomment-779000389
Merged. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] asfgit closed pull request #1488: Make Gradle build fully cacheable
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1488:
URL: https://github.com/apache/groovy/pull/1488
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1488: Make Gradle build fully cacheable
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1488:
URL: https://github.com/apache/groovy/pull/1488#issuecomment-778599244
> According to the Apache rules, binary files are not allowed to include in codebase, e.g. gradle/wrapper/gradle-wrapper.jar
Actually, the jar can be in the codebase but must not be in a release (in particular the source release). So, that part of the PR looks okay to me. We already have bootstrap steps described in the README for getting that jar when using the source release.
Also, we track dependency and tool version changes via a new issue in Jira. Would you be able to create that @serandel?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on a change in pull request #1488: Make Gradle build fully cacheable
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on a change in pull request #1488:
URL: https://github.com/apache/groovy/pull/1488#discussion_r576297656
##########
File path: gradle/verification-metadata.xml
##########
@@ -1,42 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-
--->
-<!--
- This file declares the dependency verification metadata for dependencies used by Groovy.
- When you upgrade a dependency, verification is likely to fail so you will need to update
- it.
-
- If, for whatever reason, verification fails for you, DO NOT DISABLE IT but follow the
- troubleshooting guide at https://docs.gradle.org/current/userguide/dependency_verification.html
-
- This build uses PGP verification and SHA512 checksum verification for unsigned artifacts:
-
- ./gradlew -write-verification-metadata sha512,pgp -export-keys <tasks>
-
- Then check the diff, remove the unnecessary entries (for old dependencies) and make sure
- the new ones are correct.
-
- Do not remove this header.
Review comment:
Good catch ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] melix commented on a change in pull request #1488: Make Gradle build fully cacheable
Posted by GitBox <gi...@apache.org>.
melix commented on a change in pull request #1488:
URL: https://github.com/apache/groovy/pull/1488#discussion_r576291673
##########
File path: gradle/verification-metadata.xml
##########
@@ -1,42 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-
--->
-<!--
- This file declares the dependency verification metadata for dependencies used by Groovy.
- When you upgrade a dependency, verification is likely to fail so you will need to update
- it.
-
- If, for whatever reason, verification fails for you, DO NOT DISABLE IT but follow the
- troubleshooting guide at https://docs.gradle.org/current/userguide/dependency_verification.html
-
- This build uses PGP verification and SHA512 checksum verification for unsigned artifacts:
-
- ./gradlew -write-verification-metadata sha512,pgp -export-keys <tasks>
-
- Then check the diff, remove the unnecessary entries (for old dependencies) and make sure
- the new ones are correct.
-
- Do not remove this header.
Review comment:
:x: This says "Do not remove this header" and the PR removes the header. It shows that the file hasn't been reviewed, when it should ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on pull request #1488: Make Gradle build fully cacheable
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1488:
URL: https://github.com/apache/groovy/pull/1488#issuecomment-778560107
LGTM.
According to the Apache rules, binary files are not allowed to include in codebase, e.g. gradle/wrapper/gradle-wrapper.jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] serandel commented on pull request #1488: Make Gradle build fully cacheable
Posted by GitBox <gi...@apache.org>.
serandel commented on pull request #1488:
URL: https://github.com/apache/groovy/pull/1488#issuecomment-779076653
> > According to the Apache rules, binary files are not allowed to include in codebase, e.g. gradle/wrapper/gradle-wrapper.jar
>
> Actually, the jar can be in the codebase but must not be in a release (in particular the source release). So, that part of the PR looks okay to me. We already have bootstrap steps described in the README for getting that jar when using the source release.
>
> Also, we track dependency and tool version changes via a new issue in Jira. Would you be able to create that @serandel?
It would be a pleasure, of course.
https://issues.apache.org/jira/browse/GROOVY-9942
Can you please have a look at the Fix Version and edit it if it's not the right one, please? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on a change in pull request #1488: Make Gradle build fully cacheable
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on a change in pull request #1488:
URL: https://github.com/apache/groovy/pull/1488#discussion_r576297656
##########
File path: gradle/verification-metadata.xml
##########
@@ -1,42 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-
--->
-<!--
- This file declares the dependency verification metadata for dependencies used by Groovy.
- When you upgrade a dependency, verification is likely to fail so you will need to update
- it.
-
- If, for whatever reason, verification fails for you, DO NOT DISABLE IT but follow the
- troubleshooting guide at https://docs.gradle.org/current/userguide/dependency_verification.html
-
- This build uses PGP verification and SHA512 checksum verification for unsigned artifacts:
-
- ./gradlew -write-verification-metadata sha512,pgp -export-keys <tasks>
-
- Then check the diff, remove the unnecessary entries (for old dependencies) and make sure
- the new ones are correct.
-
- Do not remove this header.
Review comment:
Good catch ;-)
Added just now:
https://github.com/apache/groovy/commit/06aa33a1a4009adcd51015c25f1f9f87f4c64eda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org