You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "mystic-lama (via GitHub)" <gi...@apache.org> on 2023/09/17 19:00:42 UTC
[GitHub] [orc] mystic-lama opened a new pull request, #1616: ORC-1504: Add lower bound check for get() in DynamicIntArray
mystic-lama opened a new pull request, #1616:
URL: https://github.com/apache/orc/pull/1616
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
The PR proposes adding check for lower bound for index passed to get() in DynamicIntArray
### Why are the changes needed?
In the absence of lower bound check, the code fails later with ArrayIndexOutOfBoundException. The code doesn't break, however the user behavior is different. This PR unifies the exception user gets, when the index is not in range
### How was this patch tested?
Unit Test case was enhanced to add the test to validate the scenario
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1616: ORC-1504: Add lower bound check for get() in DynamicIntArray
Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1616:
URL: https://github.com/apache/orc/pull/1616#issuecomment-1724838996
Thank you @mystic-lama . LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1616: ORC-1504: Add lower bound check for get() in DynamicIntArray
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1616: ORC-1504: Add lower bound check for get() in DynamicIntArray
URL: https://github.com/apache/orc/pull/1616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] zratkai commented on pull request #1616: ORC-1504: Add lower bound check for get() in DynamicIntArray
Posted by "zratkai (via GitHub)" <gi...@apache.org>.
zratkai commented on PR #1616:
URL: https://github.com/apache/orc/pull/1616#issuecomment-1722851980
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1616: ORC-1504: Add lower bound check for get() in DynamicIntArray
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1616:
URL: https://github.com/apache/orc/pull/1616#issuecomment-1725905359
Thank you, @mystic-lama , @zratkai, @guiyanakuang , @deshanxiao .
Merged to main for Apache ORC 2.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org