[GitHub] [druid] findingrish commented on a diff in pull request #14453: Improve SegmentMetadataCache visibility

["findingrish (via GitHub)" <gi...@apache.org>]

findingrish commented on code in PR #14453:
URL: https://github.com/apache/druid/pull/14453#discussion_r1235616949


##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataCache.java:
##########
@@ -403,6 +403,13 @@ public void start() throws InterruptedException
   @VisibleForTesting
   void refresh(final Set<SegmentId> segmentsToRefresh, final Set<String> dataSourcesToRebuild) throws IOException
   {
+    long startMillis = System.currentTimeMillis();
+
+    emitter.emit(ServiceMetricEvent.builder().build(

Review Comment:
   Should we report both overall time and per datasource time? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org