You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Houx Zhang (JIRA)" <ji...@apache.org> on 2011/03/27 13:57:05 UTC
[jira] [Created] (DERBY-5156) convert store/longColumn.sql into
junit test case
convert store/longColumn.sql into junit test case
-------------------------------------------------
Key: DERBY-5156
URL: https://issues.apache.org/jira/browse/DERBY-5156
Project: Derby
Issue Type: Task
Components: Test
Reporter: Houx Zhang
Assignee: Houx Zhang
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040865#comment-13040865 ]
Bryan Pendleton commented on DERBY-5156:
----------------------------------------
The patch looks good to me; the new test is nice and clear. I like the way
you segmented the testing into separate logical tests to match the original
SQL test's structure, thanks.
When you contribute a patch which contains added and/or deleted files, it
is convenient if you can also include the output of 'svn stat' so it is obvious
which files are to be added and/or deleted, as that can be hard to tell sometimes
just from reading the patch.
Should the patch also delete derbyTesting/functionTests/master/longColumn.out? It
looks like that might be missing from the patch.
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050458#comment-13050458 ]
Bryan Pendleton commented on DERBY-5156:
----------------------------------------
Thanks Houx! I will have a look
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: DERBY-5156-1.patch, DERBY-5156-1.stat, DERBY-5156-2.patch, DERBY-5156-2.stat, DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042183#comment-13042183 ]
Bryan Pendleton commented on DERBY-5156:
----------------------------------------
Thanks Houx, the stat file is very helpful. I am working on reviewing the full patch this week.
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: DERBY-5156-1.patch, DERBY-5156-1.stat, DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5156:
------------------------------
Issue & fix info: [Patch Available]
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang closed DERBY-5156.
-----------------------------
Thanks for your advice and checking, Bryan.
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: DERBY-5156-1.patch, DERBY-5156-1.stat, DERBY-5156-2.patch, DERBY-5156-2.stat, DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042599#comment-13042599 ]
Dag H. Wanvik commented on DERBY-5156:
--------------------------------------
Looking briefly at this test, it looks to me as though the results here are significant part of the test. I'd recommend including it.
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: DERBY-5156-1.patch, DERBY-5156-1.stat, DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5156:
------------------------------
Attachment: DERBY-5156-2.stat
DERBY-5156-2.patch
I have adopted your two advices, please check it!
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: DERBY-5156-1.patch, DERBY-5156-1.stat, DERBY-5156-2.patch, DERBY-5156-2.stat, DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042575#comment-13042575 ]
Bryan Pendleton commented on DERBY-5156:
----------------------------------------
The patch looks very good to me. I have two thoughts:
1) In a few places, the test deliberately causes a failure, using code like:
try {
st.executeUpdate("create index zz on testing (a)");
fail("try creating btree index on long column, should fail");
} catch (SQLException e) {
assertTrue(true);
}
It seems like it would be nice if the body of the "catch" statement verified
that we received the expected exception. That is, instead of "assertTrue(true)",
the test said something like assertSQLState("XSCB6", e);
2) I think that the existing test runs queries, and verifies not only that the
number of rows is correct, but also that the contents of the column values
that are returned by the SELECT statement match the expected results.
The new test appears to only check the number of rows returned. Is this
sufficient, for the purposes of this test? (for the other developers reading this,
please offer an opinion about whether this test will test the long column
behaviors adequately by checking the number of rows in the result set)
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: DERBY-5156-1.patch, DERBY-5156-1.stat, DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5156:
------------------------------
Attachment: DERBY-5156-1.stat
DERBY-5156-1.patch
Thanks for your checking and encourage, Bryan.
I have added a stat file and removed the longColumn.out in DERBY-5156-1.patch, please check it, thanks!
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: DERBY-5156-1.patch, DERBY-5156-1.stat, DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5156:
------------------------------
Attachment: DERBY-5156.patch
please check the patch, thanks!
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5156) convert store/longColumn.sql into
junit test case
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton resolved DERBY-5156.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.9.0.0
Issue & fix info: (was: [Patch Available])
Thanks for the updated patch, it looks great. Committed to the trunk as revision 1137258.
> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
> Key: DERBY-5156
> URL: https://issues.apache.org/jira/browse/DERBY-5156
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: DERBY-5156-1.patch, DERBY-5156-1.stat, DERBY-5156-2.patch, DERBY-5156-2.stat, DERBY-5156.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira