You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/22 07:40:05 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24674: [SPARK-27800][SQL][FOLLOWUP] Fix wrong answer on BitwiseXor test cases

HyukjinKwon commented on a change in pull request #24674: [SPARK-27800][SQL][FOLLOWUP] Fix wrong answer on BitwiseXor test cases
URL: https://github.com/apache/spark/pull/24674#discussion_r286350969
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
 ##########
 @@ -1777,7 +1777,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
           """Extended Usage:
             |    Examples:
             |      > SELECT 3 ^ 5;
-            |       2
+            |       6
 
 Review comment:
   Oh haha . I was about to say we shouldn't test this. but seems like single case to test Extended usage. Looks fine then.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org