You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/18 07:48:22 UTC
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #13215: [Improvement][dolphinscheduler-dao] use constructor based dependency injection in beans.
codecov-commenter commented on PR #13215:
URL: https://github.com/apache/dolphinscheduler/pull/13215#issuecomment-1356723964
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/13215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#13215](https://codecov.io/gh/apache/dolphinscheduler/pull/13215?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aeee15c) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/042ec74a246cc8d2103156df6d9bf206e7fbf945?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (042ec74) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev #13215 +/- ##
============================================
- Coverage 39.38% 39.34% -0.04%
+ Complexity 4279 4267 -12
============================================
Files 1067 1067
Lines 40493 40443 -50
Branches 4662 4643 -19
============================================
- Hits 15947 15912 -35
+ Misses 22758 22744 -14
+ Partials 1788 1787 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/13215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/dolphinscheduler/dao/AlertDao.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL0FsZXJ0RGFvLmphdmE=) | `30.15% <ø> (+0.83%)` | :arrow_up: |
| [.../org/apache/dolphinscheduler/dao/MonitorDBDao.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL01vbml0b3JEQkRhby5qYXZh) | `5.55% <ø> (-4.98%)` | :arrow_down: |
| [...ava/org/apache/dolphinscheduler/dao/PluginDao.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL1BsdWdpbkRhby5qYXZh) | `3.44% <ø> (-3.22%)` | :arrow_down: |
| [...eduler/dao/datasource/SpringConnectionFactory.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvU3ByaW5nQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `93.75% <ø> (-0.19%)` | :arrow_down: |
| [.../dao/repository/impl/ProcessDefinitionDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9Qcm9jZXNzRGVmaW5pdGlvbkRhb0ltcGwuamF2YQ==) | `0.00% <ø> (-4.35%)` | :arrow_down: |
| [...er/dao/repository/impl/ProcessInstanceDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9Qcm9jZXNzSW5zdGFuY2VEYW9JbXBsLmphdmE=) | `14.28% <ø> (-10.72%)` | :arrow_down: |
| [...dao/repository/impl/ProcessInstanceMapDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9Qcm9jZXNzSW5zdGFuY2VNYXBEYW9JbXBsLmphdmE=) | `0.00% <ø> (-20.00%)` | :arrow_down: |
| [...ler/dao/repository/impl/TaskDefinitionDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9UYXNrRGVmaW5pdGlvbkRhb0ltcGwuamF2YQ==) | `0.00% <ø> (-12.50%)` | :arrow_down: |
| [.../dao/repository/impl/TaskDefinitionLogDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9UYXNrRGVmaW5pdGlvbkxvZ0Rhb0ltcGwuamF2YQ==) | `0.00% <ø> (-7.70%)` | :arrow_down: |
| [...duler/dao/repository/impl/TaskInstanceDaoImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3JlcG9zaXRvcnkvaW1wbC9UYXNrSW5zdGFuY2VEYW9JbXBsLmphdmE=) | `0.00% <ø> (-3.34%)` | :arrow_down: |
| ... and [35 more](https://codecov.io/gh/apache/dolphinscheduler/pull/13215/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org