You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Raul Kripalani <ra...@evosent.com> on 2013/08/23 12:30:43 UTC
Re: git commit: camel-vertx doesn't support JDK 6
Hi Willem,
I think it could be clearer to use JUnit Assumptions [1] to disable a test
at runtime. The test would then show up as ignored rather than passed
(which would be misleading in this case).
[1] http://junit.sourceforge.net/javadoc/org/junit/Assume.html
Regards,
*Raúl Kripalani*
Apache Camel PMC Member & Committer | Enterprise Architect, Open Source
Integration specialist
http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
http://blog.raulkr.net | twitter: @raulvk
On Fri, Aug 23, 2013 at 10:22 AM, <ni...@apache.org> wrote:
> Updated Branches:
> refs/heads/master baca21110 -> 7d854c98e
>
>
> camel-vertx doesn't support JDK 6
>
>
> Project: http://git-wip-us.apache.org/repos/asf/camel/repo
> Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/7d854c98
> Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/7d854c98
> Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/7d854c98
>
> Branch: refs/heads/master
> Commit: 7d854c98e22920ca7699adbcd4f671004fb0fa3b
> Parents: baca211
> Author: Willem Jiang <ni...@apache.org>
> Authored: Fri Aug 23 17:04:17 2013 +0800
> Committer: Willem Jiang <ni...@apache.org>
> Committed: Fri Aug 23 17:04:59 2013 +0800
>
> ----------------------------------------------------------------------
> .../org/apache/camel/component/vertx/VertxRouteTest.java | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/camel/blob/7d854c98/components/camel-vertx/src/test/java/org/apache/camel/component/vertx/VertxRouteTest.java
> ----------------------------------------------------------------------
> diff --git
> a/components/camel-vertx/src/test/java/org/apache/camel/component/vertx/VertxRouteTest.java
> b/components/camel-vertx/src/test/java/org/apache/camel/component/vertx/VertxRouteTest.java
> index 4fed89f..2f08eab 100644
> ---
> a/components/camel-vertx/src/test/java/org/apache/camel/component/vertx/VertxRouteTest.java
> +++
> b/components/camel-vertx/src/test/java/org/apache/camel/component/vertx/VertxRouteTest.java
> @@ -37,11 +37,14 @@ public class VertxRouteTest extends CamelTestSupport {
> protected MockEndpoint resultEndpoint;
> protected String body1 = "{\"id\":1,\"description\":\"Message One\"}";
> protected String body2 = "{\"id\":2,\"description\":\"Message Two\"}";
> - private boolean sentMessages;
> -
> +
>
> @Test
> public void testVertxMessages() throws Exception {
> + // Vertx doesn't support JDK 1.6
> + if (isJava16()) {
> + return;
> + }
> resultEndpoint = context.getEndpoint(resultUri,
> MockEndpoint.class);
> resultEndpoint.expectedBodiesReceivedInAnyOrder(body1, body2);
>
> @@ -59,6 +62,10 @@ public class VertxRouteTest extends CamelTestSupport {
> protected RouteBuilder createRouteBuilder() throws Exception {
> return new RouteBuilder() {
> public void configure() throws Exception {
> + // Vertx doesn't support JDK 1.6
> + if (isJava16()) {
> + return;
> + }
> from(startUri).to(middleUri);
> from(middleUri).to(resultUri);
> }
>
>