You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/06 07:28:12 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4379: Add global configuration for cpu/ram limitation in service offerings
ustcweizhou opened a new pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379
…
## Description
<!--- Describe your changes in detail -->
vm.serviceoffering.cpu.cores.max and vm.serviceoffering.ram.size.max
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704627477
<b>Trillian test result (tid-2900)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37774 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4379-t2900-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 292.84 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 168.22 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704513312
> @ustcweizhou Custom Constrained and Custom Unconstrained service offerings do not adhere to the set global settings, and get created successfully despite having the the min and/or max cpu cores and memory values set above configured threshold - which is what is expected (I reckon).
>
> However, with Custom Constrained Compute offering type - when the min cpu cores / min memory is set above its max values - it still successfully creates the offering - shouldn't this ideally fail?
> 
@Pearl1594 yes, you are right.
However, when you create vm with dynamic offerings, or update vm to new offerings, cpu/ram should be checked as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704749731
Thanks @ustcweizhou , the check does happen when the offering is consumed during VM deployment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704279049
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704206527
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704279860
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704243182
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704328638
> LGTM
> Verified the fix:
>
> 1. Set "vm.serviceoffering.cpu.cores.max" to 2 and attempted to create a compute offering with CPU cores set to 4 - Failed (as expected)
> 
> 2. Set "vm.serviceoffering.ram.size.max" to 200 and attempted to create a service offering with memory of 500 MB - Failed (as expected)
> 
> 3. Created a service offering within the defined limits of vm.serviceoffering.cpu.cores.max = 2 and vm.serviceoffering.ram.size.max = 200 - Passed (as expected)
thanks @Pearl1594 !
Could you also test dynamic offerings (constrained and unconstrained) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704391302
@ustcweizhou Custom Constrained and Custom Unconstrained service offerings do not adhere to the set global settings, and get created successfully despite having the the min and/or max cpu cores and memory values set above configured threshold - which is what is expected (I reckon).
However, with Custom Constrained Compute offering type - when the min cpu cores / min memory is set above its max values - it still successfully creates the offering - shouldn't this ideally fail?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4379: Add global configuration for max cpu/ram in service offerings
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704207143
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org