You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/02/09 04:10:40 UTC
[GitHub] incubator-guacamole-client pull request #120: GUACAMOLE-201: Occasionally ve...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/120
GUACAMOLE-201: Occasionally verify client responsiveness when intercepting streams.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client monitor-sync
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit df73cdd4d654869506b94c9f449e3d985aed61fc
Author: Michael Jumper <mj...@apache.org>
Date: 2017-02-09T03:49:01Z
GUACAMOLE-201: Occasionally verify client responsiveness when intercepting streams.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #120: GUACAMOLE-201: Occasionally ve...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #120: GUACAMOLE-201: Occasionally ve...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/120#discussion_r100228151
--- Diff: guacamole/src/main/webapp/app/rest/services/tunnelService.js ---
@@ -215,6 +215,11 @@ angular.module('rest').factory('tunnelService', ['$injector',
document.body.removeChild(iframe);
};
+ // Acknowledge (and ignore) and received blobs
--- End diff --
...but yes, you're right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #120: GUACAMOLE-201: Occasionally ve...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/120#discussion_r100228085
--- Diff: guacamole/src/main/webapp/app/rest/services/tunnelService.js ---
@@ -215,6 +215,11 @@ angular.module('rest').factory('tunnelService', ['$injector',
document.body.removeChild(iframe);
};
+ // Acknowledge (and ignore) and received blobs
--- End diff --
Is this meant to say "any received blobs"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #120: GUACAMOLE-201: Occasionally ve...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/120#discussion_r100228137
--- Diff: guacamole/src/main/webapp/app/rest/services/tunnelService.js ---
@@ -215,6 +215,11 @@ angular.module('rest').factory('tunnelService', ['$injector',
document.body.removeChild(iframe);
};
+ // Acknowledge (and ignore) and received blobs
--- End diff --
No. It's meant to say "Acknowledge (and ignore) any received blobs".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---