You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/03/31 02:37:20 UTC
[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: [SPARK-42974][CORE] Restore `Utils.createTempDir` to use the `ShutdownHookManager` and clean up `JavaUtils.createTempDir` method.
LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153955764
##########
common/network-common/src/test/java/org/apache/spark/network/StreamTestHelper.java:
##########
@@ -49,7 +49,7 @@ private static ByteBuffer createBuffer(int bufSize) {
}
StreamTestHelper() throws Exception {
- tempDir = JavaUtils.createTempDir();
+ tempDir = JavaUtils.createDirectory(System.getProperty("java.io.tmpdir"), "spark");
Review Comment:
`tempDir` will cleanup by
https://github.com/apache/spark/blob/35503a535771d257b517e7ddf2adfaefefd97dad/common/network-common/src/test/java/org/apache/spark/network/StreamTestHelper.java#L90-L98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org