[GitHub] [spark] panbingkun commented on a diff in pull request #41718: [SPARK-43926][CONNECT][PYTHON] Add array_agg, array_size, cardinality, count_min_sketch,mask,named_struct,json_* to Scala and Python

["panbingkun (via GitHub)" <gi...@apache.org>]

panbingkun commented on code in PR #41718:
URL: https://github.com/apache/spark/pull/41718#discussion_r1241464167


##########
sql/core/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -368,6 +368,24 @@ object functions {
    */
   def collect_set(columnName: String): Column = collect_set(Column(columnName))
 
+  /**

Review Comment:
   Returns a count-min sketch of a column with the given esp,
         confidence and seed. The result is an array of bytes, which can be deserialized to a
         `CountMinSketch` before usage. Count-min sketch is a probabilistic data structure used for
         cardinality estimation using sub-linear space.
   
   Is the comment above more aligned?
   
   https://github.com/apache/spark/blob/00e7c08606d0b6de22604d2a7350ea0711355300/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala#L45-L48



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org