You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/03/13 18:43:48 UTC
[kudu-CR](branch-1.7.x) Remove tcmalloc spinlock contention metric
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9608
Change subject: Remove tcmalloc_spinlock_contention metric
......................................................................
Remove tcmalloc_spinlock_contention metric
Spinlock contention was removed from tcmalloc upstream, so this metric
has been set to 0 since we upgraded to tcmalloc 2.6. I looked briefly at
reverting its removal upstream, but the revert would be fairly large, so
I think it's best to just accept the loss of this instrumentation.
Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324
Reviewed-on: http://gerrit.cloudera.org:8080/9595
Tested-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 4889a9156a7e1f51b076f4bc9f44621a1b2f46e4)
---
M docs/release_notes.adoc
M src/kudu/scripts/parse_metrics_log.py
M src/kudu/util/spinlock_profiling-test.cc
M src/kudu/util/spinlock_profiling.cc
M src/kudu/util/spinlock_profiling.h
M src/kudu/util/trace.h
M src/kudu/util/trace_metrics.h
7 files changed, 7 insertions(+), 103 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/9608/1
--
To view, visit http://gerrit.cloudera.org:8080/9608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324
Gerrit-Change-Number: 9608
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.7.x) Remove tcmalloc spinlock contention metric
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9608 )
Change subject: Remove tcmalloc_spinlock_contention metric
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324
Gerrit-Change-Number: 9608
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 13 Mar 2018 21:16:40 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) Remove tcmalloc spinlock contention metric
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9608 )
Change subject: Remove tcmalloc_spinlock_contention metric
......................................................................
Remove tcmalloc_spinlock_contention metric
Spinlock contention was removed from tcmalloc upstream, so this metric
has been set to 0 since we upgraded to tcmalloc 2.6. I looked briefly at
reverting its removal upstream, but the revert would be fairly large, so
I think it's best to just accept the loss of this instrumentation.
Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324
Reviewed-on: http://gerrit.cloudera.org:8080/9595
Tested-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 4889a9156a7e1f51b076f4bc9f44621a1b2f46e4)
Reviewed-on: http://gerrit.cloudera.org:8080/9608
Tested-by: Grant Henke <gr...@gmail.com>
Reviewed-by: Grant Henke <gr...@gmail.com>
---
M docs/release_notes.adoc
M src/kudu/scripts/parse_metrics_log.py
M src/kudu/util/spinlock_profiling-test.cc
M src/kudu/util/spinlock_profiling.cc
M src/kudu/util/spinlock_profiling.h
M src/kudu/util/trace.h
M src/kudu/util/trace_metrics.h
7 files changed, 7 insertions(+), 103 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/9608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324
Gerrit-Change-Number: 9608
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.7.x) Remove tcmalloc spinlock contention metric
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: Remove tcmalloc_spinlock_contention metric
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324
Gerrit-Change-Number: 9608
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.7.x) Remove tcmalloc spinlock contention metric
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9608 )
Change subject: Remove tcmalloc_spinlock_contention metric
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins verification due to a TSAN failure on clock sync.
--
To view, visit http://gerrit.cloudera.org:8080/9608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324
Gerrit-Change-Number: 9608
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 13 Mar 2018 21:01:12 +0000
Gerrit-HasComments: No