You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/04/24 14:43:25 UTC
Review Request 58668: AMBARI-20832. Desired configs fetched in loop
via HostResourceProvider.getHosts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-20832
https://issues.apache.org/jira/browse/AMBARI-20832
Repository: ambari
Description
-------
Fix trivial typo.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db
Diff: https://reviews.apache.org/r/58668/diff/1/
Testing
-------
Unit tests: `HostResourceProviderTest` passed, other unit tests pending.
Thanks,
Attila Doroszlai
Re: Review Request 58668: AMBARI-20832. Desired configs fetched in
loop via HostResourceProvider.getHosts
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/#review172899
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On April 24, 2017, 5:07 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58668/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 5:07 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20832
> https://issues.apache.org/jira/browse/AMBARI-20832
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix trivial typo.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db
>
>
> Diff: https://reviews.apache.org/r/58668/diff/1/
>
>
> Testing
> -------
>
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests run: 4995, Failures: 0, Errors: 0, Skipped: 39
> ...
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 58668: AMBARI-20832. Desired configs fetched in
loop via HostResourceProvider.getHosts
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/#review172806
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 24, 2017, 3:07 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58668/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 3:07 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20832
> https://issues.apache.org/jira/browse/AMBARI-20832
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix trivial typo.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db
>
>
> Diff: https://reviews.apache.org/r/58668/diff/1/
>
>
> Testing
> -------
>
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests run: 4995, Failures: 0, Errors: 0, Skipped: 39
> ...
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 58668: AMBARI-20832. Desired configs fetched in
loop via HostResourceProvider.getHosts
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/#review172822
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On April 24, 2017, 11:07 a.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58668/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 11:07 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20832
> https://issues.apache.org/jira/browse/AMBARI-20832
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix trivial typo.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db
>
>
> Diff: https://reviews.apache.org/r/58668/diff/1/
>
>
> Testing
> -------
>
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests run: 4995, Failures: 0, Errors: 0, Skipped: 39
> ...
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 58668: AMBARI-20832. Desired configs fetched in
loop via HostResourceProvider.getHosts
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/
-----------------------------------------------------------
(Updated April 24, 2017, 5:07 p.m.)
Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-20832
https://issues.apache.org/jira/browse/AMBARI-20832
Repository: ambari
Description
-------
Fix trivial typo.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db
Diff: https://reviews.apache.org/r/58668/diff/1/
Testing (updated)
-------
```
$ mvn -am -pl ambari-server clean test
...
Tests run: 4995, Failures: 0, Errors: 0, Skipped: 39
...
[INFO] BUILD SUCCESS
```
Thanks,
Attila Doroszlai
Re: Review Request 58668: AMBARI-20832. Desired configs fetched in
loop via HostResourceProvider.getHosts
Posted by Laszlo Puskas <lp...@hortonworks.com>.
> On April 24, 2017, 2:51 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
> > Line 681 (original), 681 (patched)
> > <https://reviews.apache.org/r/58668/diff/1/?file=1698104#file1698104line681>
> >
> > Why not supply them anymore? Seems like a performance penality if you pass in `null`
+1
- Laszlo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/#review172788
-----------------------------------------------------------
On April 24, 2017, 2:43 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58668/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 2:43 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20832
> https://issues.apache.org/jira/browse/AMBARI-20832
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix trivial typo.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db
>
>
> Diff: https://reviews.apache.org/r/58668/diff/1/
>
>
> Testing
> -------
>
> Unit tests: `HostResourceProviderTest` passed, other unit tests pending.
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 58668: AMBARI-20832. Desired configs fetched in
loop via HostResourceProvider.getHosts
Posted by Attila Doroszlai <ad...@hortonworks.com>.
> On April 24, 2017, 4:51 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
> > Line 681 (original), 681 (patched)
> > <https://reviews.apache.org/r/58668/diff/1/?file=1698104#file1698104line681>
> >
> > Why not supply them anymore? Seems like a performance penality if you pass in `null`
>
> Laszlo Puskas wrote:
> +1
In this branch `clusterName == null` => `cluster == null` => `desiredConfigs == null` always.
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/#review172788
-----------------------------------------------------------
On April 24, 2017, 4:43 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58668/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 4:43 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20832
> https://issues.apache.org/jira/browse/AMBARI-20832
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix trivial typo.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db
>
>
> Diff: https://reviews.apache.org/r/58668/diff/1/
>
>
> Testing
> -------
>
> Unit tests: `HostResourceProviderTest` passed, other unit tests pending.
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 58668: AMBARI-20832. Desired configs fetched in
loop via HostResourceProvider.getHosts
Posted by Attila Doroszlai <ad...@hortonworks.com>.
> On April 24, 2017, 4:51 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
> > Line 681 (original), 681 (patched)
> > <https://reviews.apache.org/r/58668/diff/1/?file=1698104#file1698104line681>
> >
> > Why not supply them anymore? Seems like a performance penality if you pass in `null`
>
> Laszlo Puskas wrote:
> +1
>
> Attila Doroszlai wrote:
> In this branch `clusterName == null` => `cluster == null` => `desiredConfigs == null` always.
>
> Jonathan Hurley wrote:
> Still - that's just because of the typo; if we have the configs, we should pass them in, no?
No, this is true even after fixing the typo. The typo only affects the other branch.
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/#review172788
-----------------------------------------------------------
On April 24, 2017, 5:07 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58668/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 5:07 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20832
> https://issues.apache.org/jira/browse/AMBARI-20832
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix trivial typo.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db
>
>
> Diff: https://reviews.apache.org/r/58668/diff/1/
>
>
> Testing
> -------
>
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests run: 4995, Failures: 0, Errors: 0, Skipped: 39
> ...
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 58668: AMBARI-20832. Desired configs fetched in
loop via HostResourceProvider.getHosts
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On April 24, 2017, 10:51 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
> > Line 681 (original), 681 (patched)
> > <https://reviews.apache.org/r/58668/diff/1/?file=1698104#file1698104line681>
> >
> > Why not supply them anymore? Seems like a performance penality if you pass in `null`
>
> Laszlo Puskas wrote:
> +1
>
> Attila Doroszlai wrote:
> In this branch `clusterName == null` => `cluster == null` => `desiredConfigs == null` always.
Still - that's just because of the typo; if we have the configs, we should pass them in, no?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/#review172788
-----------------------------------------------------------
On April 24, 2017, 11:07 a.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58668/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 11:07 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20832
> https://issues.apache.org/jira/browse/AMBARI-20832
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix trivial typo.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db
>
>
> Diff: https://reviews.apache.org/r/58668/diff/1/
>
>
> Testing
> -------
>
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests run: 4995, Failures: 0, Errors: 0, Skipped: 39
> ...
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 58668: AMBARI-20832. Desired configs fetched in
loop via HostResourceProvider.getHosts
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/#review172788
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
Line 681 (original), 681 (patched)
<https://reviews.apache.org/r/58668/#comment245832>
Why not supply them anymore? Seems like a performance penality if you pass in `null`
- Jonathan Hurley
On April 24, 2017, 10:43 a.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58668/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 10:43 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20832
> https://issues.apache.org/jira/browse/AMBARI-20832
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix trivial typo.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f604a7f8be9b2dad7810e46444ae79ead73f8a98
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db
>
>
> Diff: https://reviews.apache.org/r/58668/diff/1/
>
>
> Testing
> -------
>
> Unit tests: `HostResourceProviderTest` passed, other unit tests pending.
>
>
> Thanks,
>
> Attila Doroszlai
>
>