[GitHub] kafka pull request #3382: KAFKA-4260: Check for nonroutable address in adver...

[tombentley <gi...@git.apache.org>]

GitHub user tombentley opened a pull request:

    https://github.com/apache/kafka/pull/3382

    KAFKA-4260: Check for nonroutable address in advertised.listeners

    As described in KAFKA-4260, when `listeners=PLAINTEXT://0.0.0.0:9092` (note the 0.0.0.0 "bind all interfaces" IP address) and `advertised.listeners` is not specified it defaults to `listeners`, but it makes no sense to advertise 0.0.0.0 as it's not a routable IP address.
    
    This patch checks for a 0.0.0.0 host in `advertised.listeners` (whether via default or not) and fails with a meaningful error if it's found.
    
    This contribution is my original work and I license the work to the project under the project's open source license.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tombentley/kafka advertised.listeners

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3382
    
----
commit 4286adcecbf9de28ffe66ca5afd6626bc9cace1a
Author: Tom Bentley <tb...@redhat.com>
Date:   2017-06-20T10:40:22Z

    KAFKA-4260: Check for nonroutable address is advertised.listeners

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3382: KAFKA-4260: Check for nonroutable address in adver...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3382


---