You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "Shwetha G S (JIRA)" <ji...@apache.org> on 2014/09/09 12:06:29 UTC
[jira] [Comment Edited] (FALCON-665) Handle message consumption
failures in JMSMessageConsumer
[ https://issues.apache.org/jira/browse/FALCON-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126802#comment-14126802 ]
Shwetha G S edited comment on FALCON-665 at 9/9/14 10:05 AM:
-------------------------------------------------------------
{code}
+ private void closeTopicSubscriberQuietly() {
+ if (topicSubscriber != null) {
+ try {
+ topicSubscriber.close();
+ } catch (JMSException ignore) {
+ // ignored
}
- if (connection != null) {
+ }
+ }
+
+ private void closeTopicSessionQuietly() {
+ if (topicSession != null) { // unsubscribe the durable topic topicSubscriber
+ try {
+ topicSession.unsubscribe(CLIENT_ID);
+ topicSession.close();
+ } catch (JMSException ignore) {
+ // ignored
+ }
+ }
+ }
+
+ private void closeConnectionQuietly() {
+ if (connection != null) {
+ try {
connection.close();
+ } catch (JMSException ignore) {
+ // ignored
}
{code}
Can we log the exception? Thanks for taking this up
was (Author: shwethags):
{code}
+ private void closeTopicSubscriberQuietly() {
+ if (topicSubscriber != null) {
+ try {
+ topicSubscriber.close();
+ } catch (JMSException ignore) {
+ // ignored
}
- if (connection != null) {
+ }
+ }
+
+ private void closeTopicSessionQuietly() {
+ if (topicSession != null) { // unsubscribe the durable topic topicSubscriber
+ try {
+ topicSession.unsubscribe(CLIENT_ID);
+ topicSession.close();
+ } catch (JMSException ignore) {
+ // ignored
+ }
+ }
+ }
+
+ private void closeConnectionQuietly() {
+ if (connection != null) {
+ try {
connection.close();
+ } catch (JMSException ignore) {
+ // ignored
}
{code}
Can we log the exception? Looks good otherwise. Thanks for taking this up
> Handle message consumption failures in JMSMessageConsumer
> ---------------------------------------------------------
>
> Key: FALCON-665
> URL: https://issues.apache.org/jira/browse/FALCON-665
> Project: Falcon
> Issue Type: Improvement
> Components: messaging
> Affects Versions: 0.6
> Reporter: Venkatesh Seetharam
> Assignee: Venkatesh Seetharam
> Priority: Critical
> Fix For: 0.6
>
> Attachments: FALCON-665-review.patch
>
>
> Not sure which Queue ([~shwethags], [~shaik.idris])?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)