You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/11/10 23:43:53 UTC
[kudu-CR] tablet copy: Rename TabletCopySession -> TabletCopySourceSession
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5041
to review the following change.
Change subject: tablet copy: Rename TabletCopySession -> TabletCopySourceSession
......................................................................
tablet copy: Rename TabletCopySession -> TabletCopySourceSession
This opens the way for a TabletCopyClientSession later.
Change-Id: I123fd339faec3bd53353861adcb501bf8b88764f
---
M src/kudu/tserver/tablet_copy_service.cc
M src/kudu/tserver/tablet_copy_service.h
M src/kudu/tserver/tablet_copy_session-test.cc
M src/kudu/tserver/tablet_copy_session.cc
M src/kudu/tserver/tablet_copy_session.h
5 files changed, 36 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/5041/1
--
To view, visit http://gerrit.cloudera.org:8080/5041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I123fd339faec3bd53353861adcb501bf8b88764f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet copy: Rename TabletCopySession -> TabletCopySourceSession
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tablet copy: Rename TabletCopySession -> TabletCopySourceSession
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I123fd339faec3bd53353861adcb501bf8b88764f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tablet copy: Rename TabletCopySession -> TabletCopySourceSession
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tablet copy: Rename TabletCopySession -> TabletCopySourceSession
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I123fd339faec3bd53353861adcb501bf8b88764f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tablet copy: Rename TabletCopySession -> TabletCopySourceSession
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: tablet copy: Rename TabletCopySession -> TabletCopySourceSession
......................................................................
tablet copy: Rename TabletCopySession -> TabletCopySourceSession
This opens the way for a TabletCopyClientSession later.
Change-Id: I123fd339faec3bd53353861adcb501bf8b88764f
Reviewed-on: http://gerrit.cloudera.org:8080/5041
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tserver/tablet_copy_service.cc
M src/kudu/tserver/tablet_copy_service.h
M src/kudu/tserver/tablet_copy_session-test.cc
M src/kudu/tserver/tablet_copy_session.cc
M src/kudu/tserver/tablet_copy_session.h
5 files changed, 36 insertions(+), 38 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I123fd339faec3bd53353861adcb501bf8b88764f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>