You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/04/16 08:44:00 UTC
[jira] [Work logged] (HIVE-26146) Handle missing hive.acid.key.index in the fixacidkeyindex utility
[ https://issues.apache.org/jira/browse/HIVE-26146?focusedWorklogId=757568&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757568 ]
ASF GitHub Bot logged work on HIVE-26146:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/22 08:43
Start Date: 16/Apr/22 08:43
Worklog Time Spent: 10m
Work Description: asolimando opened a new pull request, #3216:
URL: https://github.com/apache/hive/pull/3216
… utility
Minor code quality improvement:
- Removed unused private parameter builderName and associated ctor in OrcRecordUpdater.KeyIndexBuilder
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
There is a utility in hive which can validate/fix corrupted hive.acid.key.index: `hive --service fixacidkeyindex`.
The utility throws a NPE if the hive.acid.key.index metadata entry is missing, the patch allows to keep processing the ORC file and insert the missing hive.acid.key.index metadata.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
ORC acid files can be legally missing this property, so handling such cases is needed.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added a test covering the case in `TestFixAcidKeyIndex`:
```
mvn test -Dtest=TestFixAcidKeyIndex -pl ql
```
Issue Time Tracking
-------------------
Worklog Id: (was: 757568)
Remaining Estimate: 0h
Time Spent: 10m
> Handle missing hive.acid.key.index in the fixacidkeyindex utility
> -----------------------------------------------------------------
>
> Key: HIVE-26146
> URL: https://issues.apache.org/jira/browse/HIVE-26146
> Project: Hive
> Issue Type: Improvement
> Components: ORC, Transactions
> Affects Versions: 4.0.0-alpha-2
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Critical
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is a utility in hive which can validate/fix corrupted _hive.acid.key.index_:
> {code:bash}
> hive --service fixacidkeyindex
> {code}
> At the moment the utility throws a NPE if the _hive.acid.key.index_ metadata entry is missing:
> {noformat}
> ERROR checking /hive-dev-box/multistripe_ko_acid.orc
> java.lang.NullPointerException
> at org.apache.hadoop.hive.ql.io.orc.FixAcidKeyIndex.validate(FixAcidKeyIndex.java:183)
> at org.apache.hadoop.hive.ql.io.orc.FixAcidKeyIndex.checkFile(FixAcidKeyIndex.java:147)
> at org.apache.hadoop.hive.ql.io.orc.FixAcidKeyIndex.checkFiles(FixAcidKeyIndex.java:130)
> at org.apache.hadoop.hive.ql.io.orc.FixAcidKeyIndex.main(FixAcidKeyIndex.java:106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.apache.hadoop.util.RunJar.run(RunJar.java:308)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:222)
> {noformat}
> The aim of this ticket is to handle such case in order to support re-generating this metadata entry even when it is missing.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)