[GitHub] eiri commented on issue #526: Fix _local_docs end-point

[gi...@git.apache.org]

eiri commented on issue #526: Fix  _local_docs end-point
URL: https://github.com/apache/couchdb/pull/526#issuecomment-312327929
 
 
   @davisp sorry, I totally forgot about this PR!
   
   I tried modifying `fabric_view_all_docs` initially and then went with new module for three reasons:
   1. code got somehow confusing for first-time readers with usage of all `null`, numbers for offset and total and `nil` for exclusion of update_seq.
   1. code around that spawned process for getting doc count in `go/5` for `POST` with `keys` was rather ugly and running the whole thing as it is and then just throwing away the result felt like a waste.
   1.  shared config parameters and error log messages saying `_all_docs` were going to be confusing in production
   
   I agree there are lot of repetition, but it felt more cleaner to separate this functionality. If you think it's excessive I can amend `fabric_view_all_docs` instead.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services